Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Double Click To Insert Emoji Using OSX Emoji Panel 馃槥 #12950

Closed
mjbvz opened this issue Sep 28, 2016 · 7 comments
Closed

Cannot Double Click To Insert Emoji Using OSX Emoji Panel 馃槥 #12950

mjbvz opened this issue Sep 28, 2016 · 7 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2016

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Sep 28, 2016

VSCode 1.6 Insiders
OSX 10.11

Steps to Reproduce
  1. Open blank text document with UTF-8 encoding.
  2. Open the emoji panel
  3. Double click on one to insert it into current document
Expected

Emoji inserted into file

Actual

Two characters are inserted and rendered as missing symbols:

sep-28-2016 15-46-13

This seems to be a regression since 1.5. Could be related to the electron 1.3 upgrade?
@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 28, 2016

You can copy and paste them in just fine, it just seems to be using the panel that produces the problem.

@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 28, 2016

This also happens on Windows using the keyboard:

image

Most are rendered as two question marks, but a few do get rendered for some reason.

@mjbvz
Copy link
Contributor Author

mjbvz commented Sep 28, 2016

@alexandrudima, I just was talking with @seanmcbreen and he mentioned some recent work to fix emojis crashing code. Could this bug be related to #12329?

@joaomoreno
Copy link
Member

joaomoreno commented Sep 29, 2016 •
edited

This used to work, yeah.

Assigning to September for discussion.

@joaomoreno joaomoreno added this to the September 2016 milestone Sep 29, 2016
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2016
@isidorn isidorn modified the milestones: September 2016, October 2016 Sep 30, 2016
@roblourens roblourens mentioned this issue Sep 30, 2016
Closed
@thedaniel
Copy link

Did this get discussed?

@alexdima alexdima added macos Issues with VS Code on MAC/OS X and removed macos Issues with VS Code on MAC/OS X labels Oct 24, 2016
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Oct 28, 2016
@ramya-rao-a
Copy link
Contributor

This still happens in Windows using the virtual keyboard

@ramya-rao-a ramya-rao-a reopened this Nov 15, 2016
@ramya-rao-a ramya-rao-a removed the verified Verification succeeded label Nov 15, 2016
@ramya-rao-a
Copy link
Contributor

Will use #15303 to track the Windows issue

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Nov 15, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
6 participants
@thedaniel @joaomoreno @isidorn @alexdima @mjbvz @ramya-rao-a