Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support number and integer object values and arrays in Settings editor #129592

Closed
TylerLeonhardt opened this issue Jul 27, 2021 · 1 comment
Closed

Support number and integer object values and arrays in Settings editor #129592

TylerLeonhardt opened this issue Jul 27, 2021 · 1 comment
Assignees
@rzhao271
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Milestone
November 2021

Comments

@TylerLeonhardt
Copy link
Member

Testing #129448

where all values are type string or boolean (otherwise the setting won't render in the settings editor)

If I do:

                                     "additionalProperties": {
						"type": "number" // or integer or null
					},

Then I get:

image
@rzhao271 rzhao271 added feature-request Request for new features or functionality settings-editor VS Code settings editor issues labels Jul 27, 2021
@rzhao271 rzhao271 added this to the Backlog milestone Jul 27, 2021
@rzhao271 rzhao271 changed the title Support number and integer Support number and integer object values in Settings editor Aug 5, 2021
@rzhao271 rzhao271 mentioned this issue Sep 10, 2021
Closed
@rzhao271 rzhao271 modified the milestones: Backlog, November 2021 Oct 29, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Nov 5, 2021 •
edited

This issue is more of a debt one. Currently, the validation occurs after the object has been saved, whereas it should come before that. Additionally, only after the validation should the object values be parsed to the correct types.

Edit: The exact same issue occurs with the array renderer, meaning that arrays of non-nullable numbers and integers currently aren't supported.

@rzhao271 rzhao271 changed the title Support number and integer object values in Settings editor Support number and integer object values and arrays in Settings editor Nov 5, 2021
rzhao271 added a commit that referenced this issue Nov 9, 2021
@rzhao271
Add unit tests for numeric arrays
1ed9a2d 
Ref #129592
rzhao271 added a commit that referenced this issue Nov 9, 2021
@rzhao271
Toughen validation for numerical objects
b44b731 
Ref #129592
rzhao271 added a commit that referenced this issue Nov 10, 2021
@rzhao271
Render numerical arrays in the Settings editor
5317d21 
Ref #129592
@rzhao271 rzhao271 mentioned this issue Nov 22, 2021
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan settings-editor VS Code settings editor issues
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
3 participants
@TylerLeonhardt @rzhao271 and others