Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertically center walkthrough Markdown content #129733

Closed
alexweininger opened this issue Jul 29, 2021 · 3 comments
Closed

Vertically center walkthrough Markdown content #129733

alexweininger opened this issue Jul 29, 2021 · 3 comments
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
November 2021

Comments

@alexweininger
Copy link
Member

alexweininger commented Jul 29, 2021 •
edited

I think vertically centering walkthrough Markdown content would improve the look quite a bit.

Actual

Here is what Markdown content currently looks like in walkthroughs:

image

Expected

Here is what I would like it to look like (I faked this by adding <br> tags):

image
@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug getting-started polish Cleanup and polish issue labels Aug 13, 2021
@JacksonKearl JacksonKearl added this to the On Deck milestone Aug 13, 2021
@miguelsolorio
Copy link
Contributor

Also saw this in the Python extension, the markdown rendering also has font sizes that are larger than the content on the left so it throws off the hierarchy:

CleanShot 2021-09-13 at 10 14 35@2x

@miguelsolorio miguelsolorio mentioned this issue Sep 13, 2021
Closed
@JacksonKearl JacksonKearl modified the milestones: On Deck, September 2021 Sep 13, 2021
@PabloLION
Copy link

PabloLION commented Oct 24, 2021 •
edited

May I ask how do you invoke this tab? I don't know how to do it.
I tried >Get Started: Open Walkthrough... but it is of the general VS code
=== update:
I solved this. The command I run should show a quick picker and just pick the corresponding one.

@JacksonKearl JacksonKearl modified the milestones: October 2021, On Deck Oct 25, 2021
@JacksonKearl JacksonKearl modified the milestones: On Deck, November 2021 Nov 2, 2021
@miguelsolorio miguelsolorio added the verified Verification succeeded label Nov 9, 2021
@miguelsolorio
Copy link
Contributor

Looks good 👏

CleanShot 2021-11-09 at 10 23 41@2x

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@JacksonKearl @alexweininger @miguelsolorio @PabloLION and others