Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: unknown handler unregisterCommentController #130239

Closed
bpasero opened this issue Aug 6, 2021 · 4 comments
Closed

Error: unknown handler unregisterCommentController #130239

bpasero opened this issue Aug 6, 2021 · 4 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
October 2021

Comments

@bpasero
Copy link
Member

bpasero commented Aug 6, 2021

Seeing this in insiders dev tools:

ERR unknown handler: Error: unknown handler
    at o.$unregisterCommentController (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2631:52143)
    at r._doInvokeHandler (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1551:11989)
    at r._invokeHandler (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1551:11673)
    at r._receiveRequest (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1551:10335)
    at r._receiveOneMessage (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1551:9122)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1551:7218
    at l.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:1712)
    at n.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:16477)
    at u._receiveMessage (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:21743)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:18621
    at l.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:60:1712)
    at b.acceptChunk (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:13838)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:76:13186
    at Socket.T (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2899:159022)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
@rebornix rebornix added this to the August 2021 milestone Aug 9, 2021
@rebornix rebornix added the comments Comments Provider/Widget/Panel issues label Aug 9, 2021
@rebornix rebornix modified the milestones: August 2021, September 2021 Aug 22, 2021
@alexr00 alexr00 mentioned this issue Aug 27, 2021
Closed
@rebornix rebornix modified the milestones: September 2021, On Deck Sep 29, 2021
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Oct 11, 2021
@Ventilador
Copy link

Could it be related with this? (top right of the terminal)
image

i have a very similar stack trace error on the output tab (Log (Window) one)

[2021-10-12 08:59:31.463] [renderer1] [info] Starting extension host with pid 904.
[2021-10-12 08:59:31.798] [renderer1] [error] [Extension Host] (node:904) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Code --trace-deprecation ...` to show where the warning was created)
[2021-10-12 09:00:12.527] [renderer1] [error] unknown handler: Error: unknown handler
    at o.$unregisterCommentController (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2620:53257)
    at g._doInvokeHandler (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1505:13095)
    at g._invokeHandler (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1505:12779)
    at g._receiveRequest (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1505:11441)
    at g._receiveOneMessage (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1505:10119)
    at vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1505:8215
    at l.fire (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1712)
    at a.fire (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:16680)
    at c._receiveMessage (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:21950)
    at vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:18828
    at l.fire (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:69:1712)
    at S.acceptChunk (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:14041)
    at vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:85:13389
    at Socket._ (vscode-file://vscode-app/c:/Users/Ventilador/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2923:167116)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
[2021-10-12 11:15:16.939] [renderer1] [info] Starting extension host with pid 18172.
[2021-10-12 11:15:17.204] [renderer1] [error] [Extension Host] (node:18172) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Code --trace-deprecation ...` to show where the warning was created)

This is happening in regular vscode, not insiders

Version: 1.61.0 (user setup)
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:13:09.652Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19042

@bpasero
Copy link
Member Author

bpasero commented Oct 13, 2021

This also appears in integration tests:

 ✓ no rpc, createNotebookController(...)
  vscode API - globalState / workspaceState
unknown handler: Error: unknown handler
    at MainThreadComments.$unregisterCommentController (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/api/browser/mainThreadComments.js:310:23)
    at RPCProtocol._doInvokeHandler (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/services/extensions/common/rpcProtocol.js:399:27)
    at RPCProtocol._invokeHandler (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/services/extensions/common/rpcProtocol.js:384:45)
    at RPCProtocol._receiveRequest (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/services/extensions/common/rpcProtocol.js:311:32)
    at RPCProtocol._receiveOneMessage (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/services/extensions/common/rpcProtocol.js:234:26)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/workbench/services/extensions/common/rpcProtocol.js:115:52
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/common/event.js:435:38)
    at BufferedEmitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/common/ipc.net.js:380:35)
    at PersistentProtocol._receiveMessage (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/common/ipc.net.js:659:41)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/common/ipc.net.js:515:83
    at Emitter.fire (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/common/event.js:435:38)
    at ProtocolReader.acceptChunk (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/common/ipc.net.js:194:37)
    at vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/common/ipc.net.js:163:61
    at Socket.listener (vscode-file://vscode-app/Users/bpasero/Development/Microsoft/vscode-electron-11.x/out/vs/base/parts/ipc/node/ipc.net.js:33:40)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:188:23)
    ✓ state

@bpasero
Copy link
Member Author

bpasero commented Oct 19, 2021

@rebornix can this please be resolved? makes my life really hard seeing through logs and always finding this error when I want to diagnose my own issues.

@rebornix
Copy link
Member

Not clear why the unregister happens before it's registered but for now I removed the throw.

@rzhao271 rzhao271 modified the milestones: On Deck, October 2021 Oct 26, 2021
@mjbvz mjbvz added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
6 participants
@rebornix @bpasero @rzhao271 @Ventilador @mjbvz and others