Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor does not ask to save when closing #13095

Closed
chrmarti opened this issue Sep 30, 2016 · 4 comments
Closed

Diff editor does not ask to save when closing #13095

chrmarti opened this issue Sep 30, 2016 · 4 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor mode issues important Issue identified as high-priority verified Verification succeeded
Milestone
September 2016

Comments

@chrmarti
Copy link
Contributor

  • VSCode Version: Code - Insiders 1.6.0-insider (c968226, 2016-09-30T17:37:14.267Z)
  • OS Version: Windows_NT ia32 10.0.14393
  • Extensions: chrmarti.regex-0.0.6, DavidAnson.vscode-markdownlint-0.5.0, dbaeumer.vscode-eslint-1.0.6, eg2.tslint-0.5.39, ms-vscode.csharp-1.4.1, msjsdiag.debugger-for-chrome-0.5.2, seanmcbreen.Spell-0.8.6

Smoke-testing

Steps to Reproduce:

  1. Open diff editor from Git viewlet
  2. Make change in current version
  3. Close editor -> no dialog asking for saving which is inconsistent with the regular editor

Open Editors shows no editor, but 1 UNSAVED. Closing the window / opening another folder correctly asks for saving the file.
@Tyriar Tyriar added the diff-editor Diff editor mode issues label Oct 3, 2016
@alexdima alexdima assigned bpasero and unassigned alexdima Oct 6, 2016
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Oct 6, 2016
@bpasero bpasero added this to the September Recovery 2016 milestone Oct 6, 2016
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Oct 6, 2016
@bpasero bpasero closed this as completed in 4f9fe72 Oct 6, 2016
bpasero added a commit that referenced this issue Oct 6, 2016
@bpasero
Diff editor does not ask to save when closing (fixes #13095)
98c9e61
@bpasero
Copy link
Member

bpasero commented Oct 6, 2016

@chrmarti great catch, I pushed a fix. Can you please verify? the motivation for the change was to allow to close a dirty diff editor if the file is opened anywhere else. Only the last editor containing the resource (either diff editor or normal editor) should prompt the user for saving.

@chrmarti
Copy link
Contributor Author

chrmarti commented Oct 6, 2016

@bpasero The regular editor always asks, even if there is still a diff editor with the same file open. That doesn't match your description of what should happen. The original bug is fixed though. (Tested when running from source, will verify when we have a new build.)

@chrmarti chrmarti added the verified Verification succeeded label Oct 6, 2016
@chrmarti
Copy link
Contributor Author

chrmarti commented Oct 6, 2016

Verified in todays insiders with the above mentioned caveat.

@bpasero
Copy link
Member

bpasero commented Oct 7, 2016

@chrmarti yes you are right and I think that is ok because it may confuse users that they can close a normal dirty editor when only a diff editor is open to the side.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release diff-editor Diff editor mode issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
September 2016
Development

No branches or pull requests
5 participants
@egamma @bpasero @Tyriar @alexdima @chrmarti