Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Selection background is not rendered correctly #131458

Closed
wenfangdu opened this issue Aug 24, 2021 · 4 comments
Closed

[Bug] Selection background is not rendered correctly #131458

wenfangdu opened this issue Aug 24, 2021 · 4 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2021

Comments

@wenfangdu
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: v1.60.0-insider
  • OS Version: Windows 10

Steps to Reproduce:

Notice at the second round of selections, the second foo isn't highlighted after pressing Escape:

STG 2021-08-24 09_26_16
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras labels Aug 30, 2021
@hediet hediet added good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Oct 25, 2021
@maldahleh
Copy link
Contributor

I'm interested in trying this out. Would you have any tips on where to start?

@alexdima
Copy link
Member

alexdima commented Nov 1, 2021

@maldahleh The logic for this is implemented here

@maldahleh
Copy link
Contributor

@alexdima Thank you

@pdrgds
Copy link

pdrgds commented Nov 7, 2021

@alexdima fixed on #136625 - let me know if anything needs to be changed.

alexdima added a commit that referenced this issue Nov 18, 2021
@alexdima
Merge pull request #136625 from pdrgds/main
d9b65b6 
fix #131458
@alexdima alexdima added this to the November 2021 milestone Nov 18, 2021
@alexdima alexdima removed help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Nov 18, 2021
@roblourens roblourens added the verified Verification succeeded label Dec 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
7 participants
@roblourens @hediet @alexdima @maldahleh @wenfangdu @pdrgds and others