Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[github.dev] All "Run" options for notebooks should lead to the "Continue Working On" prompt options #132057

Closed
SiddhanthUnnithan opened this issue Sep 1, 2021 · 14 comments
Closed

[github.dev] All "Run" options for notebooks should lead to the "Continue Working On" prompt options #132057

SiddhanthUnnithan opened this issue Sep 1, 2021 · 14 comments
Assignees
@roblourens
Labels
github-codespaces notebook polish Cleanup and polish issue web Issues related to running VSCode in the web
Milestone
October 2021

Comments

@SiddhanthUnnithan
Copy link

SiddhanthUnnithan commented Sep 1, 2021 •
edited

TL;DR

Show the "Continue Working On" quick-pick options to users when invoking a "run" operation from within a notebook.

Overview

Currently, users are shown the following options to select kernels and run code in notebooks:

  1. Select kernel prompt in the toolbar (right-hand-side).
  2. Per-cell run button.

If the user does not have an extension installed which contributes kernels, they are shown a quick-pick prompt to "Install kernels from the marketplace". Clicking on this option will open the marketplace pane, filtered to show the Jupyter extension.

The Jupyter extension is currently unavailable in the web and will continue to be disabled until there is a clear run/execution story. Other extensions which contribute kernels (e.g., vscode-pyodide, kusto), are not Microsoft "official" extensions and thus cannot be shown as recommended extensions to install.

If the user does not have an extension installed which contributes kernels to use with a notebook, they should be shown quick-pick options equivalent to the "Continue Working On" button in the web, as an alternative to the current kernel installation prompt. Users will be given the option to graduate to desktop VS Code or a Codespace, both of which support environments in which the user can configure kernels and run their notebook cells.

We can think about a better graduation experience when moving from the web client to both desktop and codespaces, but that will be covered in a separate issue. For now we want both "upgrade" options to be shown to users instead of recommending to install kernels.

Desired Flow

The user opens a notebook in the web client, without having extensions installed that contribute a kernel.
image

The user clicks on any of the highlighted "run" options.
image

The user is shown a quick-pick prompt with options to continue working in a different environment.
image

Note

This flow is only applicable for the web client. In the desktop-client, the user should be recommended to install Jupyter and the appropriate language extensions based on the content of their notebook (feature covered in another issue).
@SiddhanthUnnithan SiddhanthUnnithan added web Issues related to running VSCode in the web notebook labels Sep 1, 2021
@greazer
Copy link
Contributor

greazer commented Sep 3, 2021

In summary, the suggestion here is that for the web scenario only, rather than pushing users to install the Jupyter and Python extensions in their web environment to perform an execution task (which won't work in the immediate term), push them directly to the "Continue Working On..." workflow.

@reconlabs-sergio
Copy link

This issue is the only result I found in the whole internets with the words "install kernels from the marketplace". Turns out that since today I cannot run any of my notebooks on VSCode

Version: 1.59.1 (Universal)
Commit: 3866c35
Date: 2021-08-19T11:53:52.479Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin arm64 20.3.0

I am prompted to install the kernels from the marketplace and taken to the extension page for Jupyter (@id:ms-toolsai.jupyter), which I already have installed.

Please help!!!

@rebornix rebornix assigned roblourens and unassigned rebornix Sep 15, 2021
@greazer greazer added this to the On Deck milestone Oct 6, 2021
@greazer
Copy link
Contributor

greazer commented Oct 6, 2021

This was on September but didn't finished. Would really like it for October.

@deepwilson
Copy link

deepwilson commented Oct 8, 2021 •
edited

Same issue here..
Not yet resolved
Currently I have to reinstall Jupyter to run the notebook every time

@ductai199x
Copy link

This issue hampered my work so much! Please make this a priority. Thank you

@greazer greazer mentioned this issue Oct 11, 2021
Closed
13 tasks
@roblourens roblourens added the polish Cleanup and polish issue label Oct 13, 2021
@roblourens roblourens modified the milestones: On Deck, October 2021 Oct 18, 2021
@roblourens
Copy link
Member

The approach is to let remotehub contribute a menu item to the cell execute menu. This menu will be proposed-only (private). That part is done, I just need to add the contribution to remotehub.

roblourens added a commit that referenced this issue Oct 22, 2021
@roblourens
Add "NotebookCellExecutePrimary" menu, towards #132057
21e5f0c
@roblourens
Copy link
Member

Notification
Oct-25-2021 15-19-42

Modal prompt
image

All the text in the quick pick title
image

I prefer the modal

@tanhakabir
Copy link
Contributor

I like the modal open the best too. I think it'd be easy to miss the notification

@roblourens
Copy link
Member

Also, this will be scoped to the jupyter-notebook type specifically. I was including notebookKernelCount == 0 in the when clause, but you can have notebooks that will never have kernels (like the markdown notebook). I think the right when clause is "isWeb && remoteHub:hasVirtualFolders && notebookType == jupyter-notebook && notebookKernelCount == 0"

@claudiaregio
Copy link

I think I prefer the 3rd just because it reduces a click for the user.

The first two options require this flow:

  1. Click run
  2. Click "Continue Working On..."
  3. Click locally
  4. Click open (hopefully a one time thing if they select the check box)
    image
  5. Click open
    image
  6. Select save location
  7. VS Code opens
  8. Reload

Since there is already quite a lengthy process/number of steps to get from web to vs code local if we can reduce number of clicks for the user that would be a better experience

@roblourens
Copy link
Member

I see that, but I think putting lots of text in that title space is unusual and not how it's meant to be used. Depending on language and window width, it could be several lines too.

@claudiaregio
Copy link

Could the text be trimmed? Personally I think it could just say "Running cells not available in web editor". Especially since the input box has Choose how you would like to continue working, followed by the options they can pick from. I think most users would understand that

@adarshanand67
Copy link

the

Did you get the solution ??
I am facing a similar issue!
Kindly help, it has hampered my work a lot :(

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
github-codespaces notebook polish Cleanup and polish issue web Issues related to running VSCode in the web
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
11 participants
@roblourens @rebornix @SiddhanthUnnithan @greazer @tanhakabir @claudiaregio @deepwilson @ductai199x @adarshanand67 @reconlabs-sergio and others