Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable view is not redrawn when moved to a different panel #132072

Closed
joyceerhl opened this issue Aug 11, 2021 · 4 comments
Closed

Variable view is not redrawn when moved to a different panel #132072

joyceerhl opened this issue Aug 11, 2021 · 4 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview-views Webview views in the sidebar and panel
Milestone

Comments

@joyceerhl
Copy link
Contributor

Originally reported by @thor4 in microsoft/vscode-jupyter#6993 (comment)

  1. Create a notebook
  2. Run a cell which defines a variable
  3. Variable shows up in the Jupyter: Variables view
  4. Right click on the Jupyter: Variables title
  5. Select 'Move Panel Right'
  6. 🐛 variable view UI never reappears

recording (14)

@IanMatthewHuff
Copy link
Member

It's interesting. The variable view can be dragged from bottom to sidebar just fine. It gets a dispose and then recreated. But when that entire panel is moved it doesn't get a visibility change, or a dispose or anything like that which I can see. I might actually try to repro this with a super simple example and see if there is a similar issue.

@IanMatthewHuff
Copy link
Member

I can actually repro this with the vscode webview-view sample.
image
The Calico Colors control also disappears when you move the panel. Oddly enough, just looking deeper now, there seems to be some sort of "welcome-view" element that seems to have replaced it?

@IanMatthewHuff
Copy link
Member

Repro is just the same basic steps as initially listed using webview-view sample. I dragged the Calico Colors control from the sidebar into the bottom panel (still worked). Then I used Move Panel Right on the bottom set of panels. The control was gone and didn't come back for me.

@IanMatthewHuff IanMatthewHuff transferred this issue from microsoft/vscode-jupyter Sep 1, 2021
@IanMatthewHuff IanMatthewHuff removed their assignment Sep 1, 2021
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview-views Webview views in the sidebar and panel labels Sep 16, 2021
@mjbvz mjbvz added this to the On Deck milestone Sep 16, 2021
@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Sep 16, 2021
@mjbvz mjbvz modified the milestones: On Deck, October 2021 Oct 22, 2021
@mjbvz mjbvz closed this as completed in 1eb38d7 Oct 22, 2021
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Oct 27, 2021
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded webview-views Webview views in the sidebar and panel
Projects
None yet
Development

No branches or pull requests

4 participants
@IanMatthewHuff @mjbvz @joyceerhl and others