Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-request for a gutter display option. #13212

Closed
terrybrash opened this issue Oct 4, 2016 · 7 comments
Closed

Feature-request for a gutter display option. #13212

terrybrash opened this issue Oct 4, 2016 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@terrybrash
Copy link

With everything gutter-related turned off (line numbers, code folding, etc.) there's still significant padding between the code and the edge of the editor: http://imgur.com/MT41OKD

Sublime Text has an option to completely hide the gutter leaving only a few pixels of padding: http://imgur.com/a/1Dsp3

So, an "editor.gutter": true/false option that mimics Sublime Text would be great.

@Tyriar Tyriar added the feature-request Request for new features or functionality label Oct 5, 2016
@jrieken jrieken removed their assignment Oct 5, 2016
@alexdima
Copy link
Member

alexdima commented Oct 6, 2016

We also have editor.glyphMargin but that is hard-coded to be true by the workbench for breakpoint setting reasons. You can also disable editor.folding to gain even more space.

@alexdima alexdima assigned bpasero and isidorn and unassigned alexdima Oct 6, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 6, 2016

I think it is fair to be able to disalbe glyphMargin for people that do not care about debugging.
So I would bring back this option - but would make it explicit in the comment of that configuraiton that the glyph margin is used for breakpoint managment and disabling it will make the debugging experince worse.

Let me know what others think
ping @weinand

@alexdima
Copy link
Member

alexdima commented Oct 6, 2016

@isidorn We could assign defaultConfig.glyphMargin to true somewhere statically such that it is true by default, and remove the hard coding (when it would be disabled, one could define breakpoints only with F9). We could be more fancy and try to do something like: if there is a breakpoint set in a file the glyphMargin is forcefully set to true, otherwise the user setting is respected.

@bpasero bpasero removed their assignment Oct 6, 2016
@isidorn isidorn added this to the October 2016 milestone Oct 6, 2016
@terrybrash
Copy link
Author

@alexandrudima "editor.folding": false is set in my screenshot above.

@isidorn
Copy link
Contributor

isidorn commented Oct 14, 2016

@alexandrudima nice idea for automatically revelaing glyph maring if there is a breakpoint - however currently I have an issue that I can not depend from BaseTextEditor to the DebugService - it does not get injected. Will add this smartness if I sort this out with @bpasero
update: not possible to depend on debug service from BaseTextEditor since they are in different layers

@alexdima
Copy link
Member

@isidorn Please be aware that any change you do to the editor default options result in a change in the standalone editor too. In the standalone editor, since the first release the glyph margin has been off by default.

I have corrected the error via 27c2cf4

image

@isidorn
Copy link
Contributor

isidorn commented Oct 24, 2016

@alexandrudima thanks a lot! Will be aware in the future.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants