Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging settings tab to another editor group clears search query #133444

Closed
zsalzbank opened this issue Sep 20, 2021 · 1 comment · Fixed by #158199
Closed

Dragging settings tab to another editor group clears search query #133444

zsalzbank opened this issue Sep 20, 2021 · 1 comment · Fixed by #158199
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
August 2022

Comments

@zsalzbank
Copy link

Issue Type: Bug

  1. Open the settings UI.
  2. Search for a setting (e.g. "inlay").
  3. Drag the settings tab to a new editor group. Note that the search you entered previously has been cleared.
Untitled.mov

VS Code version: Code 1.60.0 (e7d7e9a, 2021-09-01T10:54:53.442Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 x 2200)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.02GB free)
Process Argv --crash-reporter-id 726080a9-504a-4ce7-82e2-a7fc09b1cb07
Screen Reader no
VM 0%
Extensions (26)
Extension Author (truncated) Version
vscode-css-formatter aes 1.0.1
vscode-nginx-conf ahm 0.1.3
reorder-lines-by-length ara 1.0.2
docs-view bie 0.0.9
pgformatter bra 1.17.0
vscode-eslint dba 2.1.25
gitlens eam 11.6.0
vscode-diff fab 1.4.2
shell-format fox 7.1.0
go gol 0.27.2
postgresql JPT 0.0.2
rainbow-csv mec 1.9.1
render-crlf med 1.5.21
template-string-converter meg 0.5.3
python ms- 2021.9.1230869389
vscode-pylance ms- 2021.9.2
jupyter ms- 2021.8.2041215044
jupyter-keymap ms- 1.0.0
debugger-for-chrome msj 4.13.0
nbsp-vscode pos 0.0.1
vscode-commons red 0.0.6
vscode-yaml red 0.22.0
final-newline sam 0.3.2
vscode-hexdump sle 1.8.1
change-case wma 1.0.0
markdown-all-in-one yzh 3.4.0
A/B Experiments 
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30270858
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
vscextlangct:30333562
binariesv615:30325510
vsccppwt:30364497
pythonvssor306:30344512
bridge0708:30335490
pygetstartedc2:30360494
bridge0723:30353136
pythonrunftest32cf:30365367
pythonf5test824cf:30361778
javagetstartedt:30364666
pythonvspyt187cf:30365362
pydsgsc2:30361791
vssid140:30363603
vssur157:30367808
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Sep 20, 2021
@roblourens roblourens added this to the Backlog milestone Sep 20, 2021
@rzhao271 rzhao271 assigned rzhao271 and unassigned roblourens Oct 14, 2021
@rzhao271 rzhao271 added the confirmed Issue has been confirmed by VS Code Team member label Oct 19, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Oct 20, 2021 •
edited

A function called restoreCachedState in settingsEditor2.ts is being called after the drop, which is correct.
But, the function saveState in the same file name isn't being called when the user does step 3 above.

Another repro is to use the "move editor to X group" commands. Therefore, the fix doesn't have to do directly with dnd.

@rzhao271 rzhao271 modified the milestones: Backlog, December 2021 Nov 29, 2021
@rzhao271 rzhao271 changed the title dargging settings tab to another editor group clears search Dragging settings tab to another editor group clears search Dec 9, 2021
@rzhao271 rzhao271 modified the milestones: January 2022, February 2022 Jan 19, 2022
@rzhao271 rzhao271 mentioned this issue Feb 10, 2022
Closed
@rzhao271 rzhao271 modified the milestones: February 2022, March 2022 Feb 23, 2022
@rzhao271 rzhao271 modified the milestones: March 2022, April 2022 Mar 21, 2022
@rzhao271 rzhao271 changed the title Dragging settings tab to another editor group clears search Dragging settings tab to another editor group clears search query Apr 18, 2022
@rzhao271 rzhao271 mentioned this issue Apr 18, 2022
Closed
@rzhao271 rzhao271 modified the milestones: April 2022, May 2022 Apr 22, 2022
@rzhao271 rzhao271 modified the milestones: May 2022, On Deck, June 2022 May 25, 2022
This was referenced Jun 14, 2022
Closed
Closed
@rzhao271 rzhao271 modified the milestones: June 2022, July 2022 Jun 27, 2022
@rzhao271 rzhao271 modified the milestones: July 2022, August 2022 Jul 22, 2022
rzhao271 added a commit that referenced this issue Aug 15, 2022
@rzhao271
Implement getViewState, fixes #133444
2cb9301
@rzhao271 rzhao271 mentioned this issue Aug 15, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 15, 2022
m-tmatma pushed a commit to m-tmatma/vscode that referenced this issue Aug 16, 2022
@rzhao271
Implement getViewState, fixes microsoft#133444 (microsoft#158199)
01797ab 
* Implement getViewState, fixes microsoft#133444

* Fix viewstate vs restore scenario collision
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 16, 2022
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Implement getViewState, fixes #133444 microsoft/vscode
5 participants
@roblourens @IanMatthewHuff @zsalzbank @rzhao271 @VSCodeTriageBot