New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting multiple lines #133699
Comments
I think I now see this is referring to the extra character highlighted before the cursor |
This reproduces for me. Works only in a Jupyter notebook cell, and the actual contents don't matter, just select a character in the middle of a line and then press up/down to extend the selection to another line. |
Yes absolutely, @NotWearingPants ! |
@Badr-MOUFAD @NotWearingPants can anyone of you test if you can reproduce this issue by running Code with |
I actually reproduced this issue in latest Insiders with GH Notebook, when word wrap is turned on |
@rebornix The root cause is this CSS rule:
There are two problems that lead to this bug: the editor does not support transparent background colors and CSS targeting the There are multiple reasons we don't support having the editor background be transparent, one is that it leads to very poor compositor speeds, as the compositor will spend a lot more CPU/GPU to blend these non-opaque layers. Also, the transparent editor background color will lead to poor rendering of fonts on Windows, which will no longer use LCD text rendering. Kapture.2021-10-22.at.13.26.31.mp4 |
@alexdima thanks for the investigation and detailed explanation. @misolori can you please help update the default colors we use in the core for cell editor background? |
Doing a quick prototype of removing the transparency I can confirm that this fixes the issue: CleanShot.2021-10-22.at.11.39.14.mp4I'll work on finalizing the colors and push a fix shortly |
Environment data
Expected behaviour
When selecting multiple lines, only the selected parts using the cursor must be highlighted.
Actual behaviour
It is a bit disturbing to see extra unselected parts being highlighted. Even, it might mislead to copy/paste the wrong piece of code.
Steps to reproduce:
Refer to the gif below to reproduce this behavior
Logs
Output for
Jupyter
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toJupyter
)The text was updated successfully, but these errors were encountered: