Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate typescript language info into one item #133731

Closed
jrieken opened this issue Sep 24, 2021 · 3 comments
Closed

Consolidate typescript language info into one item #133731

jrieken opened this issue Sep 24, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues verified Verification succeeded

Comments

@jrieken
Copy link
Member

jrieken commented Sep 24, 2021

Having three items looks quite verbose and it is hard to tell what belongs together and what not (we should maybe add the source of the message but I don't believe it will make things nicer in this case)

I would merge the information of the upper two TS items into the first, e.g have the version information followed by the project and support-depth information. Note that you use markdown-links for further commands.

Screen Shot 2021-09-24 at 14 46 39

mjbvz added a commit that referenced this issue Sep 27, 2021
For #133731

No need to show this normally since project intellisense is the default
@mjbvz
Copy link
Contributor

mjbvz commented Sep 27, 2021

I've pushed a change to only show this when you are single file mode as it's not typically useful otherwise

@mjbvz mjbvz added this to the October 2021 milestone Sep 27, 2021
@mjbvz mjbvz added the typescript Typescript support issues label Sep 27, 2021
@mjbvz mjbvz modified the milestones: October 2021, September 2021 Sep 29, 2021
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 29, 2021
@mjbvz mjbvz closed this as completed in c03da8b Sep 29, 2021
@mjbvz
Copy link
Contributor

mjbvz commented Sep 29, 2021

@jrieken I've consolidated this to a single IntelliSense status item. I also tweaked some other parts of the ui

When you open a file that is in partial mode, we now show:

Screen Shot 2021-09-28 at 6 33 05 PM (3)

Otherwise we show the tsconfig (or tell the user that they don't have a tsconfig)

Please give this a try in the next insiders and let me know if you have any other suggestions

@jrieken
Copy link
Member Author

jrieken commented Sep 29, 2021

Looking much better but I am still no super-fan of the dedicated tsconfig-entry. It seems a bit thin and could be merge with the version. It's also unlikely that I would pin those - they also seem to be too generic for that and I wonder if API to suppress pinning is needed?

@jrieken jrieken added the verified Verification succeeded label Sep 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@jrieken @mjbvz and others