Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revealing an in-editor terminal also reveals the terminal pane #134053

Closed
firelizzard18 opened this issue Sep 28, 2021 · 0 comments · Fixed by #135347
Closed

Revealing an in-editor terminal also reveals the terminal pane #134053

firelizzard18 opened this issue Sep 28, 2021 · 0 comments · Fixed by #135347
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2021

Comments

@firelizzard18
Copy link

Issue Type: Bug

  • Set terminal.integrated.defaultLocation to editor
  • Hide the output/terminal panel
  • Run a test
  • Click 'Show Output' in the testing view
  • The test output terminal is shown as an editor tab, but the terminal panel is also un-hidden

I'm not sure how to reproduce this without extensions, since the main way I see it is when running tests, which are provided by extensions

VS Code version: Code 1.60.1 (83bd43b, 2021-09-10T17:06:57.931Z)
OS version: Linux x64 5.10.52-gentoo
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-10850K CPU @ 3.60GHz (20 x 4800)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
rasterization: disabled_software
skia_renderer: enabled_on
video_decode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 0, 0
Memory (System) 62.62GB (48.05GB free)
Process Argv --unity-launch --crash-reporter-id 217c2155-7214-48e7-83e7-a2317fced1b9
Screen Reader no
VM 0%
DESKTOP_SESSION /usr/share/wayland-sessions/plasmawayland
XDG_CURRENT_DESKTOP KDE
XDG_SESSION_DESKTOP KDE
XDG_SESSION_TYPE wayland
Extensions (52)
Extension Author (truncated) Version
language-x86-64-assembly 13x 3.0.0
Bookmarks ale 13.2.1
quitcontrol-vscode art 4.0.0
markdown-mermaid bie 1.12.1
rails bun 0.17.8
vscode-gemfile bun 0.4.2
better-toml bun 0.3.2
solargraph cas 0.23.0
esbuild-problem-matchers con 0.0.2
systemd-unit-file coo 1.0.6
vscode-eslint dba 2.1.25
xml Dot 2.5.1
gitlens eam 11.6.0
tsl-problem-matcher eam 0.4.0
permute-lines ear 1.1.0
EditorConfig Edi 0.16.4
vscode-npm-script eg2 0.3.22
prettier-vscode esb 9.0.0
go-notebook-kernel eth 0.2.0
pick-file-command eth 0.0.1
simple-notebook-renderers eth 0.1.1
vscode-byebug eth 0.1.2
vscode-firefox-debug fir 2.9.4
remotehub Git 0.14.0
gitlab-workflow Git 3.31.0
go gol 0.28.1
vscode-graphql Gra 0.3.18
vscode-mocha-test-adapter hbe 2.13.0
vscode-test-explorer hbe 2.21.1
docomment k-- 0.1.20
template-string-converter meg 0.5.3
ruby-rubocop mis 0.8.5
remote-ssh ms- 0.65.8
remote-ssh-edit ms- 0.65.8
hexeditor ms- 1.8.2
test-adapter-converter ms- 0.1.2
vscode-markdown-notebook ms- 0.0.25
vsliveshare ms- 1.0.4836
vsliveshare-audio ms- 0.1.91
vsliveshare-pack ms- 0.4.0
debugger-for-chrome msj 4.13.0
vetur oct 0.34.1
vscode-jest Ort 4.1.2
material-icon-theme PKi 4.10.0
ruby reb 0.28.1
slim sia 0.1.2
shader sle 1.1.5
rewrap stk 1.14.0
code-spell-checker str 2.0.7
haml vay 1.0.1
vscode-ruby win 0.28.0
vscode-proto3 zxh 0.5.4
A/B Experiments 
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30364497
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30371810
dockerwalkthru:30370836
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30364666
pythonvspyt187:30373474
pydsgsc2:30361791
@meganrogge meganrogge added the terminal Integrated terminal issues label Oct 6, 2021
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member labels Oct 7, 2021
@Tyriar Tyriar modified the milestones: September 2021, October 2021 Oct 7, 2021
jeanp413 added a commit to jeanp413/vscode that referenced this issue Oct 18, 2021
@jeanp413
Properly fix microsoft#134053
967d1a6
@jeanp413 jeanp413 mentioned this issue Oct 19, 2021
Merged
meganrogge pushed a commit that referenced this issue Oct 19, 2021
@jeanp413
Properly fix #134053 (#135347)
d817eda
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

Successfully merging a pull request may close this issue.

Properly fix #134053 jeanp413/vscode
5 participants
@firelizzard18 @Tyriar @rzhao271 @meganrogge and others