Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border for side panel #134196

Closed
bpasero opened this issue Sep 30, 2021 · 2 comments
Closed

Border for side panel #134196

bpasero opened this issue Sep 30, 2021 · 2 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone
October 2021

Comments

@bpasero
Copy link
Member

bpasero commented Sep 30, 2021

Testing #133919

It looks like we put a border to separate side panel from editor area and I wonder why, because we do not do so for the side bar on the left:

image
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Sep 30, 2021
@sbatten sbatten added this to the On Deck milestone Sep 30, 2021
@sbatten sbatten closed this as completed in 30e1743 Oct 8, 2021
@sbatten sbatten modified the milestones: On Deck, October 2021 Oct 8, 2021
@bpasero
Copy link
Member Author

bpasero commented Oct 26, 2021

This works ok but trying themes such as Github Light, where a border appears on the right hand side of the side bar, I would have expected that same border to appear also for the side bar on the right. We should probably fallback to that color if defined:

image

@bpasero bpasero reopened this Oct 26, 2021
@bpasero bpasero added the verification-found Issue verification failed label Oct 26, 2021
sbatten added a commit that referenced this issue Oct 26, 2021
@sbatten
improve theming for #134196
f9943ec
@sbatten sbatten removed the verification-found Issue verification failed label Oct 26, 2021
@sbatten sbatten closed this as completed Oct 27, 2021
@bpasero
Copy link
Member Author

bpasero commented Oct 28, 2021

👏

@bpasero bpasero added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
3 participants
@bpasero @sbatten and others