Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Independent colors for bracket pair guides #134801

Closed
hediet opened this issue Oct 11, 2021 · 3 comments
Closed

Independent colors for bracket pair guides #134801

hediet opened this issue Oct 11, 2021 · 3 comments
Assignees
@hediet
Labels
bracket-pair-guides feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2021

Comments

@hediet
Copy link
Member

hediet commented Oct 11, 2021 •
edited

Each theme should optionally be able to override the default active and inactive bracket pair guide colors.
@hediet hediet added feature-request Request for new features or functionality bracket-pair-guides labels Oct 11, 2021
@hediet hediet added this to the October 2021 milestone Oct 11, 2021
@hediet hediet self-assigned this Oct 11, 2021
This was referenced Oct 11, 2021
Closed
Closed
hediet added a commit that referenced this issue Oct 25, 2021
@hediet
Implements #134801 by introducing editorBracketPairGuideBackground{1.…
208e84a 
….6} and editorBracketPairGuideActiveBackground{1..6}.
@hediet
Copy link
Member Author

hediet commented Oct 26, 2021

Implemented by 208e84a.

@hediet hediet closed this as completed Oct 26, 2021
@hediet hediet added the verification-needed Verification of issue is requested label Oct 26, 2021
@hediet
Copy link
Member Author

hediet commented Oct 26, 2021

Verification steps:

  • Configure:

"editor.guides.bracketPairs": true,
"editor.guides.bracketPairsHorizontal": true,
"workbench.colorCustomizations": {
    "editorBracketPairGuide.activeBackground1": "#ff0000",
    "editorBracketPairGuide.background1": "#aa0000"
},
  • Notice how the bracket pair guides have the configured color (depending on if the bracket pair is focused or not)

@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Oct 26, 2021
@rzhao271
Copy link
Contributor

\closedWith 208e84a

@joyceerhl joyceerhl added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bracket-pair-guides feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@hediet @rzhao271 @joyceerhl and others