Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel watcher crash from CI #135069

Closed
bpasero opened this issue Oct 14, 2021 · 1 comment · Fixed by #135209
Closed

Parcel watcher crash from CI #135069

bpasero opened this issue Oct 14, 2021 · 1 comment · Fixed by #135209
Assignees
Labels
file-watcher File watcher freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders integration-test-failure
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Oct 14, 2021

https://dev.azure.com/monacotools/Monaco/_build/results?buildId=138788&view=logs&j=672276a2-8d3a-5fab-615d-090c51352f92&t=354d3e13-3534-5793-0b68-b00f8c1d36f3

libc++abi: terminating with uncaught exception of type std::__1::system_error: mutex lock failed: Invalid argument
Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.
Renderer process crashed with: {"reason":"crashed","exitCode":6}

Steps:

  • rename src/vs/platform/files/test/node/recursiveWatcher.integrationTest.ts to src/vs/platform/files/test/node/recursiveWatcher.test.ts
  • find the subsequent watch updates watchers test and for convenience change it to test.only
  • comment out the return await timeout(5); in that test file
  • scripts/test.sh (it may require a couple of attempts)
@bpasero
Copy link
Member Author

bpasero commented Oct 16, 2021

Noticed that the unsubscribe call was not awaited properly.

@bpasero bpasero moved this from New to Done / Deferred in Electron Integration Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-watcher File watcher freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders integration-test-failure
Projects
Archived in project
Electron Integration
  
✔️ Done / Deferred
Development

Successfully merging a pull request may close this issue.

4 participants
@bpasero @deepak1556 and others