Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Interactive - Ctrl+Home and Ctrl+End should take you to the top and bottom of the IW #135340

Closed
greazer opened this issue Jul 1, 2021 · 8 comments
Assignees
Labels
important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders interactive-window polish Cleanup and polish issue
Milestone

Comments

@greazer
Copy link
Contributor

greazer commented Jul 1, 2021

If the user does not have focus within a cell inside the IW, then pressing Ctrl+Home should scroll the IW to the top, and Ctrl+End should scroll it to the bottom. Ctrl+End is the most important piece of this. We might even consider some additional UI affordance to make this possible with the mouse (ala the "New Messages below" popup you get on chat programs like Teams or Slack.

@janosh
Copy link

janosh commented Jul 9, 2021

Another somewhat similar issue is that the native notebook doesn't snap to the bottom when it was scrolled all the way down before and new content enters the IW from executing a cell. You have to manually scroll down to see what happened every time you run a cell.

@rebornix
Copy link
Member

The builtin interactive window works the same as the webview impl, hens removed bug button. We do have Ctrl+Home/End keybindings but they don't work when the focus is inside a text editor. For scrolling without changing focus, we can use the reveal* API on the notebook editor.

@joyceerhl
Copy link
Contributor

doesn't snap to the bottom when it was scrolled all the way down before and new content enters the IW from executing a cell

FWIW @janosh this should be fixed in tonight's Jupyter extension Insiders build, we were tracking this problem as microsoft/vscode-jupyter#6603 Please let us know if it's not working for you!

@janosh
Copy link

janosh commented Jul 16, 2021

@joyceerhl Thanks, good to know!

Is there also an issue tracking the fact that the whole cell input is rendered above each cell's output? The former web view was much more concise, rendering only the first line which saves a lot of scrolling. Is this intended/meant to stay? I much preferred to old behavior.

Screen Shot 2021-07-16 at 10 32 40

@joyceerhl
Copy link
Contributor

@janosh, @rebornix is checking in something like this today :)

@janosh
Copy link

janosh commented Aug 26, 2021

The native IW has gotten much better over the last few weeks! Great work!

A remaining small issue is that when switching between multiple IWs, I'm often not at the scroll position where I left off when returning to the same window. Instead the IW has usually jumped to the top. Has this been reported/is it being tracked somewhere?

@greazer
Copy link
Contributor Author

greazer commented Aug 26, 2021

@janosh, I haven't seen that particular issue reported though we do have some other autoscroll issues around. Please enter it and thanks for all the great feedback!

@greazer
Copy link
Contributor Author

greazer commented Aug 26, 2021

Setting back to a bug. The old interactive window did indeed support Ctrl+Home and Ctrl+End, provided the focus isn't in one of the code areas of an executed cell. In other words, in the new implementation, I think it's ok to make these keystrokes navigate within the code editor if the caret is currently inside the code editor. But if it's outside, then Ctrl+Home and Ctrl+End should scroll to the top and bottom of the IW.

@rebornix rebornix self-assigned this Oct 18, 2021
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Oct 18, 2021
@rebornix rebornix added important Issue identified as high-priority interactive-window polish Cleanup and polish issue labels Oct 19, 2021
@rebornix rebornix added this to the October 2021 milestone Oct 19, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders interactive-window polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

5 participants
@rebornix @greazer @joyceerhl @janosh and others