Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

welcome page: allow to theme the checkbox #135381

Closed
aeschli opened this issue Oct 19, 2021 · 2 comments
Closed

welcome page: allow to theme the checkbox #135381

aeschli opened this issue Oct 19, 2021 · 2 comments
Assignees
@JacksonKearl
Labels
editor-theming feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2021

Comments

@aeschli
Copy link
Contributor

aeschli commented Oct 19, 2021

From #120866

https://user-images.githubusercontent.com/63160225/114091024-6f153f80-98b8-11eb-80c4-679098b590c8.png

The checkbox can not be themed.

Could use the existing colors checkbox.background and checkbox.foreground
@JacksonKearl JacksonKearl added this to the October 2021 milestone Oct 19, 2021
@JacksonKearl JacksonKearl added feature-request Request for new features or functionality polish Cleanup and polish issue labels Oct 19, 2021
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Oct 26, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 26, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Oct 26, 2021 •
edited

On macOS, I still get the default checkbox colours, even though the CSS rules show the correct colours. The Settings editor checkboxes are styled correctly, though.

screenshot

@rzhao271 rzhao271 reopened this Oct 26, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested verified Verification succeeded labels Oct 26, 2021
@JacksonKearl
Copy link
Contributor

Thanks, good catch.

@JacksonKearl JacksonKearl removed the verification-found Issue verification failed label Oct 27, 2021
@tanhakabir tanhakabir added the verified Verification succeeded label Oct 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
@JacksonKearl JacksonKearl added getting-started and removed workbench-welcome Welcome page issues labels Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
editor-theming feature-request Request for new features or functionality getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
5 participants
@aeschli @rzhao271 @JacksonKearl @tanhakabir and others