Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Items button should always be rendered the same #135395

Closed
isidorn opened this issue Oct 19, 2021 · 7 comments
Closed

New Items button should always be rendered the same #135395

isidorn opened this issue Oct 19, 2021 · 7 comments
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Milestone
November 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 19, 2021

Notice how the New Items button height depends on row height. Thus it looks like inconsitent rendering and it looks broken.
I suggest that we always render it as a one line height button for consistency.

fyi @misolori

Screenshot 2021-10-19 at 16 25 40
@miguelsolorio
Copy link
Contributor

Also would love to shorten New Items to New or Updated

@JacksonKearl
Copy link
Contributor

I like Updated.

@JacksonKearl JacksonKearl added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue workbench-welcome Welcome page issues labels Oct 19, 2021
@JacksonKearl JacksonKearl added this to the October 2021 milestone Oct 19, 2021
@gjsjohnmurray
Copy link
Contributor

@JacksonKearl I don't see how your change addresses the height issue raised by @isidorn.

@JacksonKearl
Copy link
Contributor

Hm I was thinking it was wrapping due to the word break but I agree it may just be inheriting the height. Thanks, I will investigate more.

@JacksonKearl JacksonKearl reopened this Oct 20, 2021
@gjsjohnmurray
Copy link
Contributor

Hm I was thinking it was wrapping due to the word break but I agree it may just be inheriting the height. Thanks, I will investigate more.

Also, don't assume that all language translations will be a single word.

@miguelsolorio
Copy link
Contributor

+1 for limiting the description to a single line and adding an ... as the description will show up in the detail view

@JacksonKearl JacksonKearl added getting-started and removed workbench-welcome Welcome page issues labels Oct 22, 2021
@JacksonKearl JacksonKearl modified the milestones: October 2021, On Deck Oct 25, 2021
@isidorn
Copy link
Contributor Author

isidorn commented Nov 3, 2021

Thanks for fixing this. let's assign to November so we get this verified.

@isidorn isidorn modified the milestones: On Deck, November 2021 Nov 3, 2021
@isidorn isidorn added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@isidorn @gjsjohnmurray @JacksonKearl @miguelsolorio and others