Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The screen reader announces the Saving "hostingstart.html" notification pop up as "Notification list list". #135638

Closed
v-gitsay opened this issue Oct 22, 2021 · 4 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders list-widget List widget issues verified Verification succeeded workbench-notifications Notification widget issues
Milestone

Comments

@v-gitsay
Copy link

v-gitsay commented Oct 22, 2021

Actual:

NVDA announces the Saving "hostingstart.html" notification pop up as "Notification list list".

Note:

The issue is observed with JAWS.
The issue is observed with all the Notification Pop up that appear for "Initializing SSH" pop up scenario.

Expected:

NVDA should announce the Saving "hostingstart.html" notification pop up as "Notification Saving hostingstart.html".

GitHubTags: #A11yMAS;#A11yTCS;#A11ySev2;#NVDA;#JAWS;#VisualStudioCode-Win32-Apr2021;#Visual Studio Code Client;#DesktopApp;#WCAG1.3.1;#AINotInScope;#FTP;#ScreenReader;#Element:Popup;#a11y-partner;

Environment Details:

Screen Reader: NVDA/JAWS
Operating system: Windows 10

Repro Steps:

  1. Launch VS Code application.
  2. Tab till "Azure" and press enter.
  3. Tab till "app service " dropdown and press enter.
  4. Tab till "Files" dropdown and press enter.
  5. Tab to any file and press enter.
  6. Edit by adding "make changes" and save(ctrl + S) the "SRC" file..
  7. Tab till the Pop up Saving "hostingstart.html".
  8. Check if the NVDA is announcing Pop up details correctly.

User Impact:

Screen reader users will not know that which notification pop up is on focus is the NVDA only announces "Notification list list".

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Please find the below attachment for reference:
134297742-426c50b6-3277-4d1c-927c-56416326a43d

@bpasero
Copy link
Member

bpasero commented Oct 26, 2021

@joaomoreno might need your list help here. The issue above only reproduces when using Tab key to move focus into the notification toast. It does not reproduce when you select the command to focus the notification toast.

Printing the active element in both cases I see a difference: when using Tab key, the active element properties are:

image

And when I use the command (which calls focusFirst), I see:

image

Given there are more properties now, specifically around the active descendent the ARIA label is announced properly in the second case only, not the first.

Given these toasts are always just 1 list with 1 item, I wonder if either I should always just focus the first item in the list (not sure about the consequences though, esp. visually), or whether there could be a property in the list to control this?

@joaomoreno
Copy link
Member

I wonder if either I should always just focus the first item in the list

I suggest we give this a try before committing to any changes down in the list. It might be fine even visually since the List wouldn't have DOM focus. Let me know how that goes.

@bpasero
Copy link
Member

bpasero commented Oct 27, 2021

@joaomoreno tried that, but the styling is off now, at least in some themes. Check how in GH Light theme the toast appears when I call focusFirst vs not:

image

image

Maybe I need to detect the tab-key moving into the toast container and then call focusFirst on the list? That is a bit ugly tbh.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Oct 28, 2021
@bpasero
Copy link
Member

bpasero commented Oct 28, 2021

I found an elegant fix by setting the ARIA widget label to be the notification of the toast 👍

@alexr00 alexr00 added the verified Verification succeeded label Oct 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
@isidorn isidorn added the a11ymas Issue from accessibility team label Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders list-widget List widget issues verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

6 participants
@joaomoreno @bpasero @isidorn @alexr00 @v-gitsay and others