Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WSL1: Use parcel watcher for polling watch mode #135691

Closed
bpasero opened this issue Oct 23, 2021 · 6 comments
Closed

WSL1: Use parcel watcher for polling watch mode #135691

bpasero opened this issue Oct 23, 2021 · 6 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality file-watcher File watcher insiders-released Patch has been released in VS Code Insiders verified Verification succeeded WSL Issue when using WSL
Milestone
October 2021

Comments

@bpasero
Copy link
Member

bpasero commented Oct 23, 2021

Related to #134384

Implement a polling based file watcher on top of the snapshot support in parcel watcher.

//cc @aeschli
@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested file-watcher File watcher WSL Issue when using WSL labels Oct 23, 2021
@bpasero bpasero added this to the October 2021 milestone Oct 23, 2021
@bpasero bpasero self-assigned this Oct 23, 2021
@bpasero
Copy link
Member Author

bpasero commented Oct 23, 2021

Verification

  • @aeschli should verify this given he added support for fileWatcherPolling originally

When running with verbose logging, the parcel watcher will indicate that polling is used via a log message with the polling interval in the log message.

@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2021

Very cool, thanks @bpasero! I will test tomorrow.

@DonJayamanne DonJayamanne added the verified Verification succeeded label Oct 26, 2021
@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 26, 2021 •
edited

Simply awesome, makes a huge difference (Windows 11 + WS2 + Ubuntu)

@bpasero
Copy link
Member Author

bpasero commented Oct 27, 2021

I believe this needs WSL1 to verify? @aeschli when do we enable the polling based watcher?

@aeschli
Copy link
Contributor

aeschli commented Oct 27, 2021

There's a setting "remote.WSL.fileWatcher.polling": true that needs to be set and it's only applied when in a WSL1 distro.

I've tested with various distros on large projects, on the root and it looks really good. CPU usage is quite reasonable.

@aeschli aeschli removed the verification-needed Verification of issue is requested label Oct 27, 2021
@bpasero
Copy link
Member Author

bpasero commented Oct 27, 2021

Thanks!

@aeschli aeschli mentioned this issue Oct 29, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality file-watcher File watcher insiders-released Patch has been released in VS Code Insiders verified Verification succeeded WSL Issue when using WSL
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@bpasero @DonJayamanne @aeschli and others