Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewport gets pushed up repeatedly when toggling size to content width #135804

Closed
meganrogge opened this issue Oct 25, 2021 · 11 comments
Closed

viewport gets pushed up repeatedly when toggling size to content width #135804

meganrogge opened this issue Oct 25, 2021 · 11 comments
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. verified Verification succeeded
Milestone
November 2021

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Oct 25, 2021 •
edited

recording - 2021-10-25T132205 620
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. labels Oct 25, 2021
meganrogge added a commit that referenced this issue Oct 25, 2021
@meganrogge
fix viewport gets pushed up repeatedly when toggling size to content …
fcdbfd0 
…width #135804
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 28, 2021
@joyceerhl joyceerhl reopened this Oct 28, 2021
@joyceerhl joyceerhl added the verification-found Issue verification failed label Oct 28, 2021
@joyceerhl joyceerhl removed the verification-found Issue verification failed label Oct 28, 2021
@joyceerhl
Copy link
Contributor

I ran into #134293 but this specific bug seems fixed now 🥳

@rzhao271 rzhao271 mentioned this issue Oct 28, 2021
Closed
@rzhao271
Copy link
Contributor

Got a repro on pwsh

Repro

@rzhao271 rzhao271 reopened this Oct 29, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Oct 29, 2021
@meganrogge
Copy link
Contributor Author

are you on the latest insider's @rzhao271 ?

@meganrogge
Copy link
Contributor Author

I fixed this 2 days ago.

@rzhao271
Copy link
Contributor

Yep
Potential regression?

Version: 1.62.0-insider (user setup)
Commit: ff1e16e
Date: 2021-10-29T05:16:23.014Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

@meganrogge
Copy link
Contributor Author

I find it really strange that everyone but me can reproduce this
recording - 2021-10-29T112759 377
.

@meganrogge meganrogge removed the verification-found Issue verification failed label Oct 29, 2021
@meganrogge
Copy link
Contributor Author

@rzhao271 can you try in OSS off of main? I also can't repro it there.

@rzhao271
Copy link
Contributor

It's fine in OSS. Will see if it's from an extension

@rzhao271
Copy link
Contributor

It happens at a specific zoom level. In my case, it's zoom level 2.

@meganrogge
Copy link
Contributor Author

meganrogge commented Oct 29, 2021 •
edited

Thanks for investigating @rzhao271. that's very interesting. @Tyriar thoughts?

@Tyriar Tyriar mentioned this issue Nov 3, 2021
Open
@Tyriar
Copy link
Member

Tyriar commented Nov 3, 2021

Can't reproduce, I do see size is not correct when zoom level is 2 though:#136374

@Tyriar Tyriar closed this as completed Nov 3, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-layout Issue relating to resizing, scroll bar position, terminal dimensions, etc. verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
4 participants
@Tyriar @rzhao271 @meganrogge @joyceerhl