Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopening from crash dialog closes all open instances of VS Code #135906

Closed
sana-ajani opened this issue Oct 26, 2021 · 1 comment
Closed

Reopening from crash dialog closes all open instances of VS Code #135906

sana-ajani opened this issue Oct 26, 2021 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-window Window management
Milestone
October 2021

Comments

@sana-ajani
Copy link
Contributor

sana-ajani commented Oct 26, 2021 •
edited

Testing #135751

  1. Launch VS Code in one window with folder A
  2. Launch VS Code in a second window and open folder B
  3. In the second window, run process.crash and click "reopen" at the prompt
  4. Both open VS Code instances are closed and only one is reopen with folder B

Is this expected? As a user, I don't think I expected for my first window with folder A to also be affected if window B crashes?
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-window Window management labels Oct 27, 2021
@bpasero bpasero added this to the October 2021 milestone Oct 27, 2021
@bpasero
Copy link
Member

bpasero commented Oct 27, 2021

Nice catch. The issue here was that we would ask the window manager to open the folder again, but without indicating that we really want to open in a new window, not reuse any existing window.

@mjbvz mjbvz added the verified Verification succeeded label Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-window Window management
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@bpasero @sana-ajani @mjbvz and others