-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IUriIdentityService#extUri #135935
Comments
If you are talking about the following reference then, it was done because this class is created before all services are created.
At that moment, |
I think I can also replace following vscode/src/vs/workbench/api/common/extHostWorkspace.ts Lines 63 to 65 in a0a448f
with vscode/src/vs/workbench/api/common/extHostFileSystemInfo.ts Lines 53 to 55 in f5ce799
|
This is what I have found on top (basically reference search on FileSystemProviderCapabilities.PathCaseSensitive)
|
All of the above are in platform namespace and run in shared process but |
The only thing the UriIdentityService needs is the file service so it should be easy to add that to the shared process |
👍 should be easy to add anywhere the file service is there, even main process. |
Cool, then will add it in shared process. |
|
In a few places I have seen code like this
this.extUri = !!(this.capabilities & FileSystemProviderCapabilities.PathCaseSensitive) ? extUri : extUriIgnorePathCase;
. This shouldn't be needed because there isIUriIdentityService#extUri
which is the central place for this knowledgeThe text was updated successfully, but these errors were encountered: