Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashing workbench process does not bring reopen dialog on linux #135950

Closed
deepak1556 opened this issue Oct 27, 2021 · 1 comment
Closed

Crashing workbench process does not bring reopen dialog on linux #135950

deepak1556 opened this issue Oct 27, 2021 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded workbench-electron Electron-VS Code issues
Milestone
October 2021

Comments

@deepak1556
Copy link
Contributor

Testing #135751

  1. code-insiders some-folder
  2. Get process id of workbench
  3. kill -SIGSEGV <PID>

On stable the reopen dialog is presented but insiders quits the application.
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-electron Electron-VS Code issues labels Oct 27, 2021
@bpasero bpasero modified the milestones: November 2021, October 2021 Oct 27, 2021
@bpasero bpasero added the linux Issues with VS Code on Linux label Oct 27, 2021
@bpasero
Copy link
Member

bpasero commented Oct 27, 2021

A try/catch around BrowserWindow.webContents.send seems to help. The original stack from Electron is:

Error: Render frame was disposed before WebFrameMain could be accessed
    at Object.n.send (electron/js2c/browser_init.js:165:413)
    at Object.b.send (electron/js2c/browser_init.js:161:2494)
    at CodeWindow.send (/home/parallels/GitDevelopment/monaco/out/vs/platform/windows/electron-main/window.js:1029:39)

@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Oct 28, 2021
Gvozd added a commit to Gvozd/vscode that referenced this issue Nov 6, 2021
@Gvozd
fix crash by OOM, when search opened in editor (fix microsoft#135950)…
bb4a15d 
… - major memory optimization [2671Mb -> 220Mb] [1.9sec -> 1.6sec]

usecase from microsoft#133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
Gvozd added a commit to Gvozd/vscode that referenced this issue Nov 6, 2021
@Gvozd
fix crash by OOM, when search opened in editor (fix microsoft#135950)…
52b56d6 
… - additional memory optimization [220Mb -> 15Mb] [1.6sec -> 2.2sec]

Slightly slower due to gc calls

usecase from microsoft#133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
Gvozd added a commit to Gvozd/vscode that referenced this issue Nov 6, 2021
@Gvozd
fix crash by OOM, when search opened in editor (fix microsoft#135950)…
613b709 
… - performance optimization[2.2sec -> 50ms]

usecase from microsoft#133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
JacksonKearl pushed a commit that referenced this issue Nov 9, 2021
@Gvozd
133348 fix oom when search opened in editor (#136554)
fdf8f11 
* fix crash by OOM, when search opened in editor (fix #135950) - major memory optimization [2671Mb -> 220Mb] [1.9sec -> 1.6sec]

usecase from #133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor

* fix crash by OOM, when search opened in editor (fix #135950) - additional memory optimization [220Mb -> 15Mb] [1.6sec -> 2.2sec]
Slightly slower due to gc calls

usecase from #133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor

* fix crash by OOM, when search opened in editor (fix #135950) - performance optimization[2.2sec -> 50ms]

usecase from #133348 (comment)
file for search - `plugins.pkgd.min.js` from https://github.com/froala/wysiwyg-editor
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders linux Issues with VS Code on Linux verified Verification succeeded workbench-electron Electron-VS Code issues
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
4 participants
@bpasero @deepak1556 @TylerLeonhardt and others