You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pull out most xterm handling from TerminalInstance into its own class that encapsulates addons, latest write/parse, _enableWebglRenderer/other renderer stuff, customkeyhandler?, etc. The goal is to make TerminalInstance much smaller and enable easy unit testing of previously core TerminalInstance behavior by not having so many service dependencies.
Expose xterm as public ITerminalInstance to avoid creating passthrough functions like scrollToTop
Expose xterm.raw as public but only to TerminalInstance (ie. don't expose on XtermTerminal's interface)
TerminalInstance will be mostly a glue class (process manager <-> xterm), not intended to be unit testable but by integration tests
The text was updated successfully, but these errors were encountered:
Pull out most xterm handling from
TerminalInstance
into its own class that encapsulates addons, latest write/parse, _enableWebglRenderer/other renderer stuff, customkeyhandler?, etc. The goal is to makeTerminalInstance
much smaller and enable easy unit testing of previously coreTerminalInstance
behavior by not having so many service dependencies.xterm
as public ITerminalInstance to avoid creating passthrough functions like scrollToTopxterm.raw
as public but only to TerminalInstance (ie. don't expose on XtermTerminal's interface)TerminalInstance
will be mostly a glue class (process manager <-> xterm), not intended to be unit testable but by integration testsThe text was updated successfully, but these errors were encountered: