Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move management of xterm into a new "XtermTerminal" class #136055

Closed
Tracked by #136065
Tyriar opened this issue Oct 28, 2021 · 0 comments
Closed
Tracked by #136065

Move management of xterm into a new "XtermTerminal" class #136055

Tyriar opened this issue Oct 28, 2021 · 0 comments
Assignees
Labels
debt Code quality issues terminal Integrated terminal issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2021

Pull out most xterm handling from TerminalInstance into its own class that encapsulates addons, latest write/parse, _enableWebglRenderer/other renderer stuff, customkeyhandler?, etc. The goal is to make TerminalInstance much smaller and enable easy unit testing of previously core TerminalInstance behavior by not having so many service dependencies.

  • Expose xterm as public ITerminalInstance to avoid creating passthrough functions like scrollToTop
  • Expose xterm.raw as public but only to TerminalInstance (ie. don't expose on XtermTerminal's interface)
  • TerminalInstance will be mostly a glue class (process manager <-> xterm), not intended to be unit testable but by integration tests
@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Oct 28, 2021
@Tyriar Tyriar added this to the November 2021 milestone Oct 28, 2021
Tyriar added a commit that referenced this issue Oct 29, 2021
Tyriar added a commit that referenced this issue Nov 2, 2021
Tyriar added a commit that referenced this issue Nov 2, 2021
Tyriar added a commit that referenced this issue Nov 2, 2021
Tyriar added a commit that referenced this issue Nov 2, 2021
@Tyriar Tyriar closed this as completed Nov 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants