Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl+Click Links with filename:line:text don't work #136190

Closed
coezbek opened this issue Oct 31, 2021 · 3 comments
Closed

Ctrl+Click Links with filename:line:text don't work #136190

coezbek opened this issue Oct 31, 2021 · 3 comments
Assignees
@Tyriar
Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2021

Comments

@coezbek
Copy link

coezbek commented Oct 31, 2021 •
edited

Issue Type: Bug

  1. Create a file with name my_file.rb in a new repository and enter three lines of random text.
  2. Open a Terminal
  3. enter my_file.rb:1:in
  4. Try to Ctrl+Click this go open the editor on line 1
  5. Observe that VSCode shows "No result"

This bug manifests when running ruby scripts in Terminal and getting a stacktrace such as:

~/$ ruby my_file.rb 
Traceback (most recent call last):
my_file.rb:2:in `<main>': Oh oh Crash (RuntimeError)

Screenshot:

image

VS Code version: Code 1.61.2 (6cba118, 2021-10-19T14:57:20.575Z)
OS version: Windows_NT x64 10.0.19042
Restricted Mode: No
Fetching remote diagnostics for 'WSL: Ubuntu-20.04' failed: Canceled

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 x 1992)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.86GB (4.57GB free)
Process Argv
Screen Reader no
VM 57%

Fetching remote diagnostics for 'WSL: Ubuntu-20.04' failed: Canceled

Extensions: none
@coezbek
Copy link
Author

coezbek commented Nov 1, 2021

Associated question on StackOverflow: https://stackoverflow.com/q/69784676/278842

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug confirmation-pending terminal-links labels Nov 1, 2021
@meganrogge meganrogge added this to the Backlog milestone Nov 1, 2021
@Tyriar
Copy link
Member

Tyriar commented Nov 2, 2021

It actually works when running using ./:

image

Since the other case is falling back to the "word link" provider, it ends up searching the workspace for the whole path (my_file.rb:2:in). Since all these errors in ruby seem to have :in added to the end, let's add some smarts around handling that.

@Tyriar Tyriar added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Nov 2, 2021
@Tyriar Tyriar modified the milestones: Backlog, November 2021 Nov 2, 2021
@Tyriar Tyriar closed this as completed in c3be8a8 Nov 2, 2021
@Tyriar Tyriar added author-verification-requested Issues potentially verifiable by issue author verification-needed Verification of issue is requested and removed confirmation-pending unreleased Patch has not yet been released in VS Code Insiders labels Nov 2, 2021
@coezbek
Copy link
Author

coezbek commented Nov 2, 2021

Thanks! @Tyriar This is awesome!

@DonJayamanne DonJayamanne added the verified Verification succeeded label Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
author-verification-requested Issues potentially verifiable by issue author feature-request Request for new features or functionality terminal-links verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@DonJayamanne @Tyriar @coezbek @meganrogge and others