Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built in is always used for notebook renderers #136247

Closed
rchiodo opened this issue Nov 1, 2021 · 7 comments
Closed

Built in is always used for notebook renderers #136247

rchiodo opened this issue Nov 1, 2021 · 7 comments
Assignees
@rebornix @connor4312
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Milestone
November 2021

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Nov 1, 2021 •
edited

Issue Type: Bug

Create a python file with these contents:

# %% Cell Error
raise new Exception('Test')

Run this cell in the interactive window.

Expected result:
Links show up to jump back to where the exception was thrown

Actual result:
Links are not there.

The jupyter notebook renderer is not being picked to render the error.

image

VS Code version: Code - Insiders 1.62.0-insider (673165c, 2021-11-01T08:36:27.543Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.96GB (17.34GB free)
Process Argv . --crash-reporter-id 108b1212-dd8c-4594-8252-c1351bf31268
Screen Reader no
VM 0%
Extensions (23)
Extension Author (truncated) Version
vscode-eslint dba 2.2.1
prettier-vscode esb 9.0.0
remotehub Git 0.17.0
better-cpp-syntax jef 1.15.10
vscode-position jtr 1.0.3
regexp-preview Lou 0.1.5
python ms- 2021.11.1408613116-dev
vscode-pylance ms- 9999.0.0-dev
jupyter ms- 2021.10.1001408933
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.3
remote-containers ms- 0.203.0
remote-ssh-edit-nightly ms- 2021.10.19620
remote-ssh-nightly ms- 2021.10.36984
remote-wsl ms- 0.58.4
vscode-remote-extensionpack ms- 0.21.0
cpptools ms- 1.7.1
cpptools-extension-pack ms- 1.0.0
vscode-github-issue-notebooks ms- 0.0.112
vscode-selfhost-test-provider ms- 0.3.8
vscode-typescript-next ms- 4.5.20211025
rpa-eslint-snippets rav 0.0.2
rest-book tan 4.2.0

(1 theme extensions excluded)

A/B Experiments 
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythontb:30258533
pythonptprofiler:30281269
vsdfh931cf:30280410
vshan820:30294714
pythondataviewer:30285072
pythonvsuse255:30319630
vscod805cf:30301675
pythonvspyt200:30323110
vsccppwt:30382699
bridge0708:30335490
pygetstartedt2:30353727
bridge0723:30353136
pythonrunftest32:30365365
pythonf5test824:30361779
javagetstartedt:30350119
pythonvspyt187:30365360
pydsgst2:30361790
vsaa593:30376534
@rchiodo rchiodo changed the title Mimetype is always text on running a plot in the interactive window Built in is always used for notebook renderers Nov 1, 2021
@rebornix rebornix assigned connor4312 and unassigned rebornix Nov 2, 2021
@connor4312
Copy link
Member

This is using the following algorithm: #125876 (comment)

How do you think we should change this?

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 2, 2021

Shouldn't the second item here be being used?

  • If the user has explicitly selected a renderer for X, in this notebook type and workspace, use that.
  • Otherwise, if the extension providing the notebook also provides a renderer for X, use that. <-- Seems like this should be picked up
  • Otherwise, if there is a built-in renderer for X, use that. (From previous comments)
  • Otherwise, if there is another extension who renders mimetype X, use that.

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 2, 2021 •
edited

Oh no wait. The renderers for jupyter are from a separate extension. That's the failure. Blech

image

@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 2, 2021

I think we need something extra then. Some sort of preference for a renderer extension in our kernel?

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug notebook labels Nov 4, 2021
@connor4312 connor4312 added this to the October 2021 milestone Nov 4, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Nov 4, 2021

Woot! Thanks @connor4312

@alexr00 alexr00 modified the milestones: October 2021, November 2021 Nov 8, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 8, 2021

@connor4312 moving to November, since this isn't in the October release.

@rchiodo rchiodo added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
6 participants
@rebornix @DonJayamanne @connor4312 @rchiodo @alexr00 and others