Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve createModelServices and createCodeEditorServices #136380

Closed
Tracked by #136283
alexdima opened this issue Nov 3, 2021 · 0 comments
Closed
Tracked by #136283

Improve createModelServices and createCodeEditorServices #136380

alexdima opened this issue Nov 3, 2021 · 0 comments
Assignees
@alexdima
Labels
debt Code quality issues
Milestone
October 2021

Comments

@alexdima
Copy link
Member

alexdima commented Nov 3, 2021 •
edited

Accept a DisposableStore passed in and return a TestInstantiationService
@alexdima alexdima mentioned this issue Nov 3, 2021
Closed
12 tasks
@alexdima alexdima changed the title Change how createModelServices and createEditorServices work to get a DisposableStore passed in and return a TestInstantiationService @alexdima Improve createModelServices and createEditorServices to accept a DisposableStore passed in and return a TestInstantiationService Nov 3, 2021
@alexdima alexdima changed the title Improve createModelServices and createEditorServices to accept a DisposableStore passed in and return a TestInstantiationService Improve createModelServices and createEditorServices Nov 3, 2021
@alexdima alexdima changed the title Improve createModelServices and createEditorServices Improve createModelServices and createCodeEditorServices Nov 3, 2021
@alexdima alexdima self-assigned this Nov 3, 2021
alexdima added a commit that referenced this issue Nov 3, 2021
@alexdima
Improve createModelServices (#136380)
513d580
alexdima added a commit that referenced this issue Nov 3, 2021
@alexdima
Improve createCodeEditorServices (#136380)
a9a6117
@alexdima alexdima added the debt Code quality issues label Nov 3, 2021
@alexdima alexdima added this to the October 2021 milestone Nov 3, 2021
@alexdima alexdima closed this as completed Nov 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
debt Code quality issues
Projects
None yet
Milestone
October 2021
Development

No branches or pull requests
1 participant
@alexdima