Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the test message view selectable #136410

Closed
jdneo opened this issue Nov 4, 2021 · 2 comments
Closed

Make the test message view selectable #136410

jdneo opened this issue Nov 4, 2021 · 2 comments
Assignees
@connor4312
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2021

Comments

@jdneo
Copy link
Member

jdneo commented Nov 4, 2021

Currently the Java testing extension use test message view with Markdown string to show the stacktrace:
image

I found that the text in the test message view cannot be selected. Users may want to copy the trace and diagnostic from it. It would be great if we can make the widget selectable.
@jdneo
Copy link
Member Author

jdneo commented Nov 5, 2021

Thank you @connor4312

@connor4312 connor4312 added feature-request Request for new features or functionality testing Built-in testing support verification-needed Verification of issue is requested labels Nov 5, 2021
@connor4312 connor4312 added this to the November 2021 milestone Nov 5, 2021
@jdneo
Copy link
Member Author

jdneo commented Nov 8, 2021

Just tried in

Version: 1.63.0-insider (user setup)
Commit: 552af97
Date: 2021-11-05T05:16:20.583Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.19043

The selection works great!

One more feedback on the selection behavior. Currently the overflow text cannot be selected due to the overflow style is set to hidden. (I tried set it to scroll , but it will break the view's style)

Animation

@jrieken jrieken added the verified Verification succeeded label Nov 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@connor4312 connor4312

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
4 participants
@jrieken @connor4312 @jdneo and others