Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateUserConfiguration: does not trigger for workspace changes #13653

Closed
bpasero opened this issue Oct 13, 2016 · 0 comments
Closed

updateUserConfiguration: does not trigger for workspace changes #13653

bpasero opened this issue Oct 13, 2016 · 0 comments
Assignees
@chrmarti
Labels
feature-request Request for new features or functionality
Milestone
November 2016

Comments

@bpasero
Copy link
Member

bpasero commented Oct 13, 2016

I noticed a new updateUserConfiguration telemetry event which does not seem to get triggered when workspace settings are changed. Imho it would be better to have 1 thing listening on changes to user and workspace settings and report the proper telemetry for it. This would also help for #13652
@bpasero bpasero mentioned this issue Oct 13, 2016
Closed
@chrmarti chrmarti added this to the November 2016 milestone Nov 17, 2016
chrmarti added a commit that referenced this issue Nov 21, 2016
@chrmarti
Flatten configuration keys for logging (fixes #13653)
40ed39d
@chrmarti chrmarti added the feature-request Request for new features or functionality label Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
2 participants
@bpasero @chrmarti