Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add reverse continue for TimeTravel Debugging feature for Node #13705

Closed
aruneshchandra opened this issue Oct 13, 2016 · 17 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@aruneshchandra
Copy link
Member

This request builds on the following work that was done earlier to support TTD for Node in VSCode

According to some internal usability testing, we discovered a need to have a reverse continue button on the debug bar in order to enhance the usability of the time travel debugging for more complex scenarios.

/cc: @weinand, @isidorn, @roblourens, @mrkmarron

@weinand weinand self-assigned this Oct 13, 2016
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Oct 13, 2016
@weinand
Copy link
Contributor

weinand commented Oct 19, 2016

@aruneshchandra please explain the semantics of "reverse continue"

@aruneshchandra
Copy link
Member Author

"Reverse continue" is suppose to work exactly like the "Debug Continue" with the difference being that it goes backwards and is only available while debugging a TTD trace. So, when the debugger is broken into while debugging a TTD trace, hitting reverse continue should execute backwards until the first (previous) break point is hit. To enable this VSCode can pass a stepback:continue command to the debug adapter and the TTD enabled runtime should handle the rest.

@mrkmarron - do you have anything else to add ?

@weinand
Copy link
Contributor

weinand commented Oct 20, 2016

@roblourens are you supporting back-in-time debugging in node-debug2 too?

@roblourens
Copy link
Member

I don't think Node-chakra supports --inspect yet, although I think they're working on it.

@aruneshchandra
Copy link
Member Author

@roblourens is right, --inspect is not supported in Node-ChakraCore yet , but we do plan to support it.
/cc: @digitalinfinity @agarwal-sandeep

@aruneshchandra
Copy link
Member Author

any update on this ?

@weinand
Copy link
Contributor

weinand commented Oct 31, 2016

This is planned for the November release.

@weinand weinand added this to the November 2016 milestone Oct 31, 2016
@aruneshchandra
Copy link
Member Author

cool - when is the Nov release ? do we have a date ?

@isidorn
Copy link
Contributor

isidorn commented Oct 31, 2016

@aruneshchandra the plan with the dates will be posted soon on GitHub - to get notified on each iteration plan you can follow Erich on twitter https://twitter.com/erichgamma?lang=en

@aruneshchandra
Copy link
Member Author

Do we know when this might show up in Nightlies ? We will be showing a demo at NodeInteractive at the end of this month and wanted to see this in action before that.

@weinand
Copy link
Contributor

weinand commented Nov 4, 2016

We can make this happen.

@weinand
Copy link
Contributor

weinand commented Nov 9, 2016

@aruneshchandra what is the exact name for the stepaction attribute of the continue that is passed to chakra? For stepping back it was 'back'. The stepback:continue that you've mentioned above does not look proper.

@agarwal-sandeep
Copy link

Since the command is continue stepaction:"reverse" may be appropriate. @aruneshchandra @mrkmarron?

@weinand
Copy link
Contributor

weinand commented Nov 9, 2016

@isidorn I've added a reverseContinueRequest to the protocol. Please add an action button to the debug action floating palette if the supportsStepBack capability is true.

@weinand weinand assigned isidorn and unassigned weinand Nov 9, 2016
weinand added a commit to microsoft/vscode-debugadapter-node that referenced this issue Nov 9, 2016
@weinand weinand reopened this Nov 9, 2016
@weinand
Copy link
Contributor

weinand commented Nov 10, 2016

node-debug uses a value reverse for the stepaction attribute of the continue request.

@weinand
Copy link
Contributor

weinand commented Nov 11, 2016

@aruneshchandra 'reverse continue' has arrived in the Insiders build. If you install the "Mock Debug" extension, you can try the feature:

2016-11-11_14-44-09-1

@aruneshchandra
Copy link
Member Author

Thanx @weinand and @isidorn - this is great!

@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 6, 2016
@isidorn isidorn added the verified Verification succeeded label Dec 6, 2016
@egamma egamma mentioned this issue Dec 20, 2016
56 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants