Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing files when manually building vscode server #137568

Closed
jeanp413 opened this issue Nov 20, 2021 · 3 comments 路 Fixed by #137570
Closed

missing files when manually building vscode server #137568

jeanp413 opened this issue Nov 20, 2021 · 3 comments 路 Fixed by #137570
Assignees
@joaomoreno @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2021

Comments

@jeanp413
Copy link
Contributor

Steps to Reproduce:

  1. run yarn gulp vscode-reh-web-linux-x64-min
  2. 馃悰 open output folder vscode-reh-web-linux-x64/extensions/markdown-language-features and observe notebook-out folder is missing, same for markdown-math
jeanp413 added a commit to jeanp413/vscode that referenced this issue Nov 20, 2021
@jeanp413
Fixes microsoft#137568
edd3a60
@jeanp413 jeanp413 mentioned this issue Nov 20, 2021
Merged
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Nov 20, 2021
@jeanp413
Fixes microsoft#137568
48db311
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Nov 20, 2021
@jeanp413
Fixes microsoft#137568
d718935
@alexdima
Copy link
Member

These files are missing also when building vscode.

@alexdima alexdima assigned mjbvz and joaomoreno and unassigned rebornix Nov 22, 2021
@alexdima alexdima added the engineering VS Code - Build / issue tracking / etc. label Nov 22, 2021
@mjbvz mjbvz added this to the November 2021 milestone Nov 22, 2021
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Nov 23, 2021
@jeanp413
Fixes microsoft#137568
6154e6b
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Nov 23, 2021
@jeanp413
Fixes microsoft#137568
4443967
joaomoreno pushed a commit that referenced this issue Nov 24, 2021
@jeanp413
Fixes #137568 (#137570)
556ce85
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug author-verification-requested Issues potentially verifiable by issue author labels Nov 29, 2021
@jeanp413
Copy link
Contributor Author

/verified

guibber pushed a commit to guibber/vscode that referenced this issue Nov 30, 2021
@jeanp413
Fixes microsoft#137568 (microsoft#137570)
c7fa629
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Fixes missing files when manually building vscode server jeanp413/vscode
6 participants
@joaomoreno @rebornix @alexdima @mjbvz @jeanp413 and others