Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugServer property should be under configurations #13783

Closed
xanathar opened this issue Oct 14, 2016 · 6 comments
Closed

debugServer property should be under configurations #13783

xanathar opened this issue Oct 14, 2016 · 6 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2016

Comments

@xanathar
Copy link

Currently the debugServer property in launch.json is at the same level of version - that is, it's global.
In my opinion it would make more sense for it to be under the specific configurations; the benefits would be:

  • the extensions can fill launch.json appropriately (as far as I can see extensions can easily provide configurations when they are first clicked in the debug gear dropdown, but not global properties to launch.json)
  • debug extensions using programs and ones using debugServer properties could be mixed-up in the same project

Of course there is a high change that I'm missing something big - documentation about debugServer is hard to find and sparse, that being the case, sorry in advance :)
@isidorn
Copy link
Contributor

isidorn commented Oct 17, 2016

+1 for this
The downside is that we would break existing launch.json that have debugServer on top. Though most of them just have it for development of debug adapters so IMHO this might be fine

@weinand opinion?

@isidorn isidorn self-assigned this Oct 17, 2016
@weinand
Copy link
Contributor

weinand commented Oct 17, 2016

@isidorn agreed, having debugServer per launch configuration makes sense (and becomes even more important if we start to support multiple sessions).
I suggest that we start to support this and keep the global debugServer as well (but deprecate it).

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Oct 17, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 17, 2016 •
edited

@weinand the only way to depricate the debugServer is via documentation since it is currently hidden in the launch.json inteli-sense.
I also propose to support top level debug server for one sprint and then stop supporting it top level alltogether

@isidorn isidorn added this to the November 2016 milestone Oct 17, 2016
@weinand
Copy link
Contributor

weinand commented Oct 17, 2016

We should document both debugServer attributes in intellisense.

@isidorn
Copy link
Contributor

isidorn commented Oct 17, 2016 •
edited

But top level I would document it with a deprecation message.
And it can get a proper message inside the configuration

@daviwil
Copy link
Contributor

daviwil commented Oct 17, 2016

I just started using the debugServer property in the PowerShell extension and I agree, it'd be great to have it on a per-configuration basis!

@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 6, 2016
@sandy081 sandy081 added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
5 participants
@daviwil @weinand @isidorn @xanathar @sandy081