Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic hovers adding indentation with \n #14128

Closed
joshbw opened this issue Oct 21, 2016 · 6 comments
Closed

Diagnostic hovers adding indentation with \n #14128

joshbw opened this issue Oct 21, 2016 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2016

Comments

@joshbw
Copy link

joshbw commented Oct 21, 2016

  • VSCode Version: 1.6.1
  • OS Version: Win10 w/ anniversary update

Steps to Reproduce:

  1. create a diagnostic with the message property set to text that contains newlines (\n). For example:
    diagnostic.message = "\nSeverity: Critical\nHere are details about the Error";
  2. hover over whatever code is tied to the diagnostic to show the message. Prior to 1.6 this would appear as:

[Source]
Severity: Critical
Here are details about the error

As one would expect. However, in 1.6 and above both Severity and "Here are the details..." will also start with a heavy indentation, as if there are a number of tabs inserted
@roblourens
Copy link
Member

Can you share a screenshot?

@joshbw
Copy link
Author

joshbw commented Oct 21, 2016

devskim screenshot
Attached - prior to 1.6 everything was aligned in the hover. In 1.6 the first line after each \n is heavily indented as you can see

@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Oct 21, 2016
@alexdima alexdima assigned joaomoreno and unassigned alexdima Oct 27, 2016
@joaomoreno
Copy link
Member

Can you share a code snippet of what your extension is doing exactly?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Oct 27, 2016
@joshbw
Copy link
Author

joshbw commented Nov 2, 2016

Sent you an email

@joaomoreno
Copy link
Member

Can you just provide a link to the github repo or similar?

@joaomoreno
Copy link
Member

Oh nevermind, just got the email.

@joaomoreno joaomoreno added this to the November 2016 milestone Nov 9, 2016
@joaomoreno joaomoreno removed the info-needed Issue requires more information from poster label Nov 9, 2016
@jrieken jrieken added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @jrieken @alexdima @joshbw