Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input Chinese comment flash when enable semantic highlighting #141725

Closed
tjx666 opened this issue Jan 28, 2022 · 9 comments
Closed

input Chinese comment flash when enable semantic highlighting #141725

tjx666 opened this issue Jan 28, 2022 · 9 comments
Assignees
@alexdima
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug editor-input-IME Editor input of characters not on keyboard insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
February 2022

Comments

@tjx666
Copy link
Contributor

tjx666 commented Jan 28, 2022 •
edited

2022-01-24.01.48.16.mov

VSCode info:

Version: 1.64.0-insider (Universal)
Commit: 23664355e61f3fb614932a5cb16613b4d987cfb7
Date: 2022-01-21T13:27:12.081Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.2.0

rust-analyzer version: (eg. output of "Rust Analyzer: Show RA Version" command)

rust-analyzer version: baa5cd952 2022-01-23 nightly

rustc version: (eg. output of rustc -V)

rustc 1.58.0 (02072b482 2022-01-11)

@alexdima ref: rust-lang/rust-analyzer#11335
@rzhao271 rzhao271 assigned alexdima and unassigned rzhao271 Jan 28, 2022
@tjx666
Copy link
Contributor Author

tjx666 commented Feb 4, 2022

This issue is really annoying, hope to be fixed soon. @alexdima

@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 7, 2022
Closed
@tjx666
Copy link
Contributor Author

tjx666 commented Feb 18, 2022 •
edited

@alexdima

In today build insiders version, the comment seems to toggle italic and normal when input Chinese.

2022-02-18.15.20.46.mov

@alexdima alexdima added editor-input-IME Editor input of characters not on keyboard bug Issue identified by VS Code Team member as probable bug labels Feb 18, 2022
@alexdima alexdima added this to the February 2022 milestone Feb 18, 2022
@alexdima alexdima added the author-verification-requested Issues potentially verifiable by issue author label Feb 22, 2022
@tjx666
Copy link
Contributor Author

tjx666 commented Feb 22, 2022

/verified

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 22, 2022

@alexdima
I find that problem still exists when My typing word is head of line.

2022-02-23.00.47.15.mov

@alexdima alexdima reopened this Feb 22, 2022
@alexdima alexdima removed verified Verification succeeded insiders-released Patch has been released in VS Code Insiders labels Feb 22, 2022
@tjx666
Copy link
Contributor Author

tjx666 commented Feb 23, 2022

@alexdima

I find that the words would left-right shake when I inputing Chinese if line prefix with space.

2022-02-24.02.34.43.mov

@alexdima
Copy link
Member

@tjx666 I am now confident that the initial reported problem with flashing, which was caused by us changing the color of the text, has been fixed. I consider this issue to be fixed now.

Regarding your latest recording, I see that there is some "tremor", but unfortunately I am unable to reproduce:

Kapture.2022-02-24.at.17.18.57.mp4
Kapture.2022-02-24.at.17.21.34.mp4

@tjx666
Copy link
Contributor Author

tjx666 commented Feb 25, 2022 •
edited

@alexdima
Try using this popular font: https://github.com/tonsky/FiraCode.
After I unset this font to editor, the "tremor" disappear.

alexdima added a commit that referenced this issue Feb 25, 2022
@alexdima
Add +1 to the visible textarea width to avoid flickering that might b…
a3dce15 
…e caused by accumulating rounding errors (#141725)
@alexdima
Copy link
Member

@tjx666 Thank you, I could reproduce with FiraCode and have pushed a fix.

@TylerLeonhardt TylerLeonhardt added the author-verification-requested Issues potentially verifiable by issue author label Feb 25, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Feb 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug editor-input-IME Editor input of characters not on keyboard insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
5 participants
@TylerLeonhardt @alexdima @rzhao271 @tjx666 and others