Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide sidebar loses focus on terminal to editor #14550

Closed
octref opened this issue Oct 26, 2016 · 1 comment
Closed

Hide sidebar loses focus on terminal to editor #14550

octref opened this issue Oct 26, 2016 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
October 2016

Comments

@octref
Copy link
Contributor

octref commented Oct 26, 2016

  • VSCode Version: 1.7 Insider
  • OS Version: macOS 10.11.6

Steps to Reproduce:

  1. Focus on terminal
  2. Realize I want more screen width, Cmd+B to hide sidebar
  3. Now focus is on editor

I understand #14312 can be as-designed.
Toggling open sidebar -> focus on sidebar, then closing sidebar -> return focus to editor by default. This makes sense. But when terminal has focus, hiding sidebar -> focus on editor doesn't make sense.
@octref octref added the terminal Integrated terminal issues label Oct 26, 2016
@Tyriar Tyriar added workbench and removed terminal Integrated terminal issues labels Oct 26, 2016
@Tyriar Tyriar assigned bpasero and unassigned Tyriar Oct 26, 2016
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2016
@Tyriar
Copy link
Member

Tyriar commented Oct 26, 2016

I think the underlying issue is that the hide the sidebar command focuses the sidebar or forces focus on the editor.

@bpasero bpasero added this to the October 2016 milestone Oct 27, 2016
@rebornix rebornix added the verified Verification succeeded label Oct 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
October 2016
Development

No branches or pull requests
4 participants
@rebornix @bpasero @Tyriar @octref