Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook find decorations are not removed when clearing the search text #145675

Closed
lszomoru opened this issue Mar 22, 2022 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-find verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

Testing #145636

  1. Create a new .ipynb notebook with the following code in the cell
str1 = "Foo"
str2 = "Bar"

# convert both the strings into lowercase
str1 = str1.lower()
str2 = str2.lower()

# check if length is same
if(len(str1) == len(str2)):

    # sort the strings
    sorted_str1 = sorted(str1)
    sorted_str2 = sorted(str2)

    # if sorted char arrays are same
    if(sorted_str1 == sorted_str2):
        print(str1 + " and " + str2 + " are anagram.")
    else:
        print(str1 + " and " + str2 + " are not anagram.")

else:
    print(str1 + " and " + str2 + " are not anagram.")
  1. Press Cmd + F to bring up the search widget. Press s to which will display the find decorations
  2. Delete s in the find widget -> Find decorators are not being removed
    image
@rebornix
Copy link
Member

rebornix commented Mar 22, 2022

@lszomoru thanks for the report!

@rebornix rebornix added this to the March 2022 milestone Mar 22, 2022
@rebornix rebornix added notebook-find bug Issue identified by VS Code Team member as probable bug labels Mar 22, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Mar 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-find verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@rebornix @lszomoru @joyceerhl and others