-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go To description mentions line, column but it should be line, character #14598
Comments
@alexandrudima in the end I am passing a Range to the editor with start line number and start column (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/quickopen/browser/gotoLineHandler.ts#L98). Are you saying that this API talks about characters and not columns? |
@alexandrudima it is this one: So when I pass a |
@bpasero Please change your nls string such that it shows: |
Makes sense to me to use character consistently. |
To me too. |
Changed it for markers panel. |
Fixed except for the cases where the doc was referring to properties. Since these properties are API and I didn't want to break the API I left them with column. |
|
As discussed assigning to you. |
Extracted from #14585 (comment)
The text was updated successfully, but these errors were encountered: