-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save failure #14635
Comments
@ylqhust can you try to provide the issue description in english? |
I edit a file and save edit then I to edit another file . after sometimes ,I come back to see the first file .I find the first file's content is not I saved. this problem have happend many times |
@ylqhust |
Taking this back. @ylqhust As mentioned earlier, please try without extension. I have added telemetry about saving participant times, most interesting is how long format on save takes (upper bound 750ms) and how long the on-will-save-event takes (upper bound 1500ms). Turns that there are extensions host that are more or less dead. Looking at the data for 'format on save' is happy (since we enforce the timeout in the main process). However, the 'will save event' is dispatched and monitored on the extension host, meaning a dead/heavy loaded extension host might run its event listeners timely but it takes a long before that happens. During the last day we have participated in more than 10000 saves and some cases (~450) it took longer that 1500ms. |
I will put another defence mechanism in place that recovers from a dead extension host |
Verified that if I make the extension host not reply in 1750ms the save proceeds after at least 1750ms. The save participant on the extension is not canceled so there is still a chance that it eventually triggers (not sure if this is a problem @jrieken). |
Shouldn't be a problem because the extension host cancels itself after 1500ms - the additional check is there to protect from a dead/unresponsive extension host. Even when the operation gets through in time at worst it will trigger another dirty/save cycle |
I have started to have this problem yesterday. I reinstalled Version 1.12.1 (1.12.1) and can reproduce. I open a file and edit it, but VS Code does not recognize it as edited. When I save nothing happens. VSCode remembers my edits but if I view the file from another editor, the edits have not been saved. |
@alecmce I suggest to open a new issue on it. |
Steps to Reproduce:
编辑一个文件并且保存后,然后去编辑别的文件,过了一会在回来看,原来的文件保存失效,文件内容是上一次的内容,这个bug很严重啊,我的电脑上已经发生了好几次了,这个不解决只能投入atom的怀抱了
The text was updated successfully, but these errors were encountered: