Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop threshold debug square broken currently #149569

Closed
MachineMitch21 opened this issue May 15, 2022 · 0 comments · Fixed by #149570
Closed

Drop threshold debug square broken currently #149569

MachineMitch21 opened this issue May 15, 2022 · 0 comments · Fixed by #149570
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@MachineMitch21
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.67.1
  • OS Version: Windows_NT x64 10.0.19044

Steps to Reproduce:

  1. Enable the drop threshold square code in editorDropTarget.ts by uncommenting it. (Could this be wrapped in a configuration setting instead of just commenting it??)
  2. Notice linter complains about possibility of this.overlay being undefined. (Although I don't think it will ever be undefined in this code)
  3. Observe two variables are unrecognized. groupViewWidth and groupViewHeight (compilation error here)

This code is currently commented so doesn't effect production, but I would like to update this because I found the debug square to be cool and would like to use it in my development environment. Please let me know if this is the proper way to go about this sort of thing as this is my first time opening an issue. This is very low priority, but I wanted to open a pull request for this so I needed a corresponding issue.

@roblourens roblourens assigned mjbvz and unassigned roblourens May 17, 2022
@mjbvz mjbvz assigned bpasero and unassigned mjbvz May 17, 2022
@bpasero bpasero added this to the June 2022 milestone May 27, 2022
@bpasero bpasero added the debt Code quality issues label May 27, 2022
MachineMitch21 added a commit to MachineMitch21/vscode that referenced this issue May 28, 2022
MachineMitch21 added a commit to MachineMitch21/vscode that referenced this issue May 28, 2022
@bpasero bpasero modified the milestones: June 2022, May 2022 May 29, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants