Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover stays when releasing Alt and mouse is outside hover & target #150842

Closed
chrmarti opened this issue May 31, 2022 · 0 comments · Fixed by #151185
Closed

Hover stays when releasing Alt and mouse is outside hover & target #150842

chrmarti opened this issue May 31, 2022 · 0 comments · Fixed by #151185
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-hover Hover issues in the workbench
Milestone
May 2022

Comments

@chrmarti
Copy link
Contributor

Testing #150557

On mac:

  • Hover over gear icon of extension in Extensions viewlet.
  • Hover appears.
  • Press and hold Alt.
  • Hover border changes to 2px.
  • Move mouse to editor (where no hover appears).
  • Release Alt.
  • Expect hover to disappear (according to test instructions), but hover stays.

Moving the mouse into the hover and out again (while no longer pressing Alt), makes the hover disappear. Also another hover makes it disappear.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug workbench-hover Hover issues in the workbench labels May 31, 2022
@Tyriar Tyriar added this to the May 2022 milestone May 31, 2022
Tyriar added a commit that referenced this issue Jun 3, 2022
@Tyriar
Fix releasing alt sometimes not hiding locked hovers
cc80440 
- CompositeMouseTracker.isMouseIn's initial state is now true, this means
releasing alt without moving the mouse will not hide the hover
- The current hover options are now only cleared when the hover being
disposed is the active hover, this was the main cause of the problem because
if current hover options is undefined while there is an active hover weird
things could happen

Fixes #150842
Tyriar added a commit that referenced this issue Jun 3, 2022
@Tyriar
Fix releasing alt sometimes not hiding locked hovers
ea381c9 
- CompositeMouseTracker.isMouseIn's initial state is now true, this means
releasing alt without moving the mouse will not hide the hover
- The current hover options are now only cleared when the hover being
disposed is the active hover, this was the main cause of the problem because
if current hover options is undefined while there is an active hover weird
things could happen

Fixes #150842
@Tyriar Tyriar mentioned this issue Jun 3, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 3, 2022
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-hover Hover issues in the workbench
Projects
None yet
Milestone
May 2022
Development

Successfully merging a pull request may close this issue.

Fix releasing alt sometimes not hiding locked hovers microsoft/vscode
4 participants
@Tyriar @TylerLeonhardt @chrmarti @VSCodeTriageBot