Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This test delays test execution by 500ms #15116

Closed
alexdima opened this issue Nov 7, 2016 · 1 comment
Closed

This test delays test execution by 500ms #15116

alexdima opened this issue Nov 7, 2016 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
April 2017

Comments

@alexdima
Copy link
Member

alexdima commented Nov 7, 2016

Tests should run very fast such that we can develop on VSCode and run the tests often.

mocha --run out\vs\editor\contrib\find\test\common\findController.test.js

image

setTimeout(function () {
	assert.deepEqual(['3'], toArray(findController.getHistory()));
	done();
}, 500);
@sandy081
Copy link
Member

sandy081 commented Nov 8, 2016

@alexandrudima Thanks for bringing this.
I agree that having delays in tests is not good practice. In this case, it was put because to test history of find terms which are added to the history with a delay of 500ms. This is because find functionality is aggressive (starts finding immediately / on typing). Removing the delay will add each letter to the history while typing which is not good.

I would think if I can replace this delay with another better approach without any side affects.

@sandy081 sandy081 added this to the January 2017 milestone Dec 7, 2016
@sandy081 sandy081 added the debt Code quality issues label Dec 7, 2016
@sandy081 sandy081 modified the milestones: February 2017, January 2017 Jan 23, 2017
@bpasero bpasero modified the milestones: February 2017, March 2017 Feb 24, 2017
@sandy081 sandy081 modified the milestones: April 2017, March 2017 Mar 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2017
Development

No branches or pull requests
3 participants
@bpasero @alexdima @sandy081