Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default profile isn't picking up correct icon #151639

Closed
Tyriar opened this issue Jun 9, 2022 · 0 comments · Fixed by #151643
Closed

Default profile isn't picking up correct icon #151639

Tyriar opened this issue Jun 9, 2022 · 0 comments · Fixed by #151643
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-profiles verified Verification succeeded
Milestone
June 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 9, 2022 •
edited

In this screenshot the generic icon terminals were created via ctrl+shift+` and the bash icon ones were created via the dropdown menu

Screen Shot 2022-06-09 at 12 32 48 pm

This could explain some of the other default profile problems people have.

Version: 1.68.0-insider
Commit: 87630a9
Date: 2022-06-06T17:07:57.914Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 21.5.0
@Tyriar Tyriar added this to the June 2022 milestone Jun 9, 2022
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-profiles labels Jun 9, 2022
Tyriar added a commit that referenced this issue Jun 9, 2022
@Tyriar
Correctly resolve the icon asap when defaultProfile is null
2196474 
When the defaultProfile is null we don't actually know what the default
profile is until the process has been created, this is because it needs a
round trip to the pty host. This change fixes the _icon prop updating and
icon changed event firing.

Fixes #151639
@Tyriar Tyriar mentioned this issue Jun 9, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 9, 2022
@Tyriar Tyriar mentioned this issue Jun 10, 2022
Closed
@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-profiles verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Correctly resolve the icon asap when defaultProfile is null microsoft/vscode
4 participants
@Tyriar @mjbvz @meganrogge @VSCodeTriageBot