Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explorer doesn't fit width when double clicking on the resize handler #15242

Closed
msuntharesan opened this issue Nov 9, 2016 · 3 comments
Closed

Explorer doesn't fit width when double clicking on the resize handler #15242

msuntharesan opened this issue Nov 9, 2016 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2016

Comments

@msuntharesan
Copy link

  • VSCode Version: Code 1.7.1 (02611b4, 2016-11-03T13:46:46.244Z)
  • OS Version: Linux x64 4.8.6-1-ARCH
  • Extensions:
Extension Author Version
rainbow-brackets 2gua 0.0.6
vscode-markdownlint DavidAnson 0.5.0
EditorConfig EditorConfig 0.3.4
material-icon-theme PKief 1.1.3
vscode-docker PeterJausovec 0.0.7
vscode-file-peek abierbaum 1.0.1
theme-colorful-defaults aeschli 0.1.10
path-intellisense christian-kohler 1.1.0
vscode-eslint dbaeumer 1.0.8
tslint eg2 0.5.40
vscode-npm fknop 3.3.0
flow-for-vscode flowtype 0.3.3
Theme-MarkdownKit ms-vscode 0.1.1
csharp ms-vscode 1.4.1
debugger-for-chrome msjsdiag 2.2.2
vscode-mssql sanagama 0.0.4
whitespace sandcastle 0.0.4
RustyCode saviorisdead 0.19.1
theme-tesla smlombardi 0.0.1
es6-mocha-snippets spoonscen 0.0.1
guides spywhere 0.5.1
change-case wmaurer 1.0.0
JavaScriptSnippets xabikos 1.2.0
ReactSnippets xabikos 1.2.0

Steps to Reproduce:

While on Explorer tab, when you double click it used to collapse or expand to fixed width. But now if its expanded beyond the fixed with double clicking on the resize handler doesn't reduce the size it keeps expanding.
@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

Wow, good catch. No clue how we broke that...

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2016
@bpasero bpasero added this to the November 2016 milestone Nov 10, 2016
@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

This seems to be caused by 42ec7da which was a fix for #13787

@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

@joaomoreno maybe something for you as CSS wizard :). When you double click on the explorer, we compute the optimal width of the DOM nodes that contain the label of the file. Since the label has flex: 1 set, somehow the optimal width is growing and growing each time you double click.

Now, when I remove flex: 1 it works again but then this happens:

  • have a file with long text
  • enable icons in the explorer (use minimal icon theme, not seti)
  • resize the explorer
    => the label moves

editors

@bpasero bpasero mentioned this issue Nov 13, 2016
Closed
@roblourens roblourens added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
3 participants
@roblourens @bpasero @msuntharesan