Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New macOS bar - intellisense issue #15258

Closed
normalser opened this issue Nov 9, 2016 · 6 comments
Closed

New macOS bar - intellisense issue #15258

normalser opened this issue Nov 9, 2016 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster verified Verification succeeded
Milestone

Comments

@normalser
Copy link

  • VSCode Version: Code - Insiders 1.8.0-insider (ce6d578, 2016-11-09T08:41:36.673Z)
  • OS Version: Darwin x64 16.1.0
  • Extensions:

Steps to Reproduce:

image

Works ok in 1.7.1

@normalser
Copy link
Author

FYi - setting "window.titleBarStyle": "native" fixes the issue

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 10, 2016
@bpasero bpasero added this to the November 2016 milestone Nov 10, 2016
@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

@wallverb can you share how this looks like in 1.7.1 for you? I just made the comparison myself and see it behaves the same:

Native Title
image

Custom Title
image

@bpasero bpasero added the info-needed Issue requires more information from poster label Nov 10, 2016
@normalser
Copy link
Author

Custom Title:
custom

Native Title:
native

@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

@joaomoreno @alexandrudima I think the issue here is that the hover thinks the title area (when set to custom) is something to overlay because it is within the bounds of the workbench.

I see two options:

  • reduce the z-index of the title so that the hover just overlaps
  • tell the editor that there is a 22px area on top that widgets should not overlay

What do you think?

@joaomoreno
Copy link
Member

IMO, the two points need to be addressed.

The titlebar should not have a z-index at all, since no other element is placed in the same position, if our layout code is correct.

At the same time, I don't think we really benefit anything from letting overflowing widgets be rendered on that area, so maybe we should crop the area a little bit. We already do that hack for the status bar, just create go along and create a TOP_PADDING.

@bpasero
Copy link
Member

bpasero commented Nov 10, 2016

Makes sense. Pushed via 0a5a7b9

I took out those z-indexes, I have no clue why we had them in the first place. Let's see what happens.

@roblourens roblourens added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants