Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn users that their default editor will be affected when installing on Windows 10 #15304

Closed
waynebloss opened this issue Nov 10, 2016 · 6 comments
Closed

Warn users that their default editor will be affected when installing on Windows 10 #15304

waynebloss opened this issue Nov 10, 2016 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2016

Comments

@waynebloss
Copy link

  • VSCode Version: Code 1.7.1 (02611b4, 2016-11-03T13:53:14.822Z)
  • OS Version: Windows_NT ia32 10.0.14393

Steps to Reproduce:

  1. Run the installer on Windows 10.
  2. See that Register Code as an editor for supported file types is checked by default, with no warning about any consequences of leaving it checked.
  3. After installation, try to open any affected file-type and your default editor will no longer open automatically. Instead you will receive the Windows dialog that asks what program to open the file type with.

I don't know if anybody at Microsoft is still using Windows, but it's really annoying to have all of your default file openers reset. Especially for a programming tool that affects about 20 or 30 different file types that I use on a regular basis like *.js, *.css, *.less, *.jade, etc..
@waynebloss
Copy link
Author

Original issue: #15252

@joaomoreno
Copy link
Member

A quick google search shows that, unfortunately, this is a Windows issue which seems to hit many users:

http://www.tenforums.com/windows-updates-activation/40373-last-update-caused-all-custom-file-associations-reset-defaults.html

http://superuser.com/questions/1022063/windows-10-default-programs-keep-changing

It also shows that it is not entirely a Code issue. It applies to any application that has file associations. Think about VLC, iTunes, PowerPoint. Are all those affected by this?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Nov 10, 2016
@waynebloss
Copy link
Author

There's something very simple that VS Code can do about it though.

Given the really, really annoying consequences of leaving that one checkbox checked - I would make VS Code either:

  • Not leave the checkbox checked by default.
  • Change the verbiage of the checkbox label to warn the user that simply "registering" Code as a handler will cause all affected file types to no longer automatically open with their previous default handler.

Or both.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 10, 2016
@joaomoreno joaomoreno added this to the November 2016 milestone Nov 10, 2016
@joaomoreno joaomoreno self-assigned this Nov 10, 2016
@joaomoreno
Copy link
Member

I've remove the checked by default.

I've also started an email thread internally to figure out who is screwing up here.

@roblourens
Copy link
Member

@joaomoreno Still seeing this checked by default in the latest Insiders installer -
image

@roblourens roblourens reopened this Dec 8, 2016
@roblourens
Copy link
Member

Nvm, I removed my existing installation then ran the installer again, now that option and the context menu options are correctly unchecked.

@roblourens roblourens added the verified Verification succeeded label Dec 8, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2016
Development

No branches or pull requests
3 participants
@joaomoreno @roblourens @waynebloss