Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview integration tests are flaky #153066

Closed
bpasero opened this issue Jun 24, 2022 · 0 comments · Fixed by #157155
Closed

Webview integration tests are flaky #153066

bpasero opened this issue Jun 24, 2022 · 0 comments · Fixed by #157155
Assignees
@mjbvz
Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure
Milestone
August 2022

Comments

@bpasero
Copy link
Member

bpasero commented Jun 24, 2022

Looking at webview.test.ts almost all tests are skipped by now, but the remaining ones are still timing out sometimes:

For now we should skip the entire suite and then figure out a different strategy for how to deal with these tests.
bpasero added a commit that referenced this issue Jun 24, 2022
@bpasero
tests - skip all flaky webview tests (#153066)
7ea24c0
@bpasero bpasero mentioned this issue Jun 24, 2022
Merged
bpasero added a commit that referenced this issue Jun 24, 2022
@bpasero
tests - skip all flaky webview tests (#153066) (#153067)
0dfbf42
@mjbvz mjbvz added this to the August 2022 milestone Jul 27, 2022
This was referenced Aug 3, 2022
Closed
Closed
Closed
Closed
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 4, 2022
Tyriar pushed a commit that referenced this issue Aug 4, 2022
@mjbvz
Remove skipped webview tests (#157155)
c5f857f 
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 5, 2022
joyceerhl pushed a commit that referenced this issue Aug 10, 2022
@mjbvz @joyceerhl
Remove skipped webview tests (#157155)
329a5dd 
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
insiders-released Patch has been released in VS Code Insiders integration-test-failure
Projects
None yet
Milestone
August 2022
Development

Successfully merging a pull request may close this issue.

Remove skipped webview tests mjbvz/vscode
3 participants
@bpasero @mjbvz @VSCodeTriageBot