Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit session - Account selector #153526

Closed
lszomoru opened this issue Jun 28, 2022 · 2 comments · Fixed by #153766 or #153846
Closed

Edit session - Account selector #153526

lszomoru opened this issue Jun 28, 2022 · 2 comments · Fixed by #153766 or #153846
Assignees
@joyceerhl
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2022

Comments

@lszomoru
Copy link
Member

lszomoru commented Jun 28, 2022 •
edited

Testing #153386

I am seeing weird behaviour related to the account selector when trying to create and result edit sessions. the behaviour is pretty random but I am signed in to VS Code Desktop with both GitHub and Microsoft, and I am signed in to https://insiders.vscode.dev with GitHub:

  1. On web, I am asked to pick an account to use for the edit session even though I am signed in with one account
  2. On desktop, there are times when I am asked to pick an account when creating an edit session and there are times when that does not happen
  3. On desktop, i have seen a case when I tried to restore an edit session, the account picker showed up, even though I was seeing in the background that the edit session was successfully restored

Apologies if this is not helpful, but I am happy to either set up a screen share, or collect additional logs if available.
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster labels Jun 28, 2022
@joyceerhl joyceerhl mentioned this issue Jun 28, 2022
Merged
@joyceerhl
Copy link
Contributor

On web, I am asked to pick an account to use for the edit session even though I am signed in with one account

Do you mean that after signing into edit sessions once on web, you are asked to sign in again to apply edit sessions on web?

On desktop, there are times when I am asked to pick an account when creating an edit session and there are times when that does not happen

This should happen the first time that you do anything with edit sessions on desktop, or any subsequent occasion when auth fails (e.g. an expired token). If you see this happen unexpectedly, the Log (Window) channel might help.

On desktop, i have seen a case when I tried to restore an edit session, the account picker showed up, even though I was seeing in the background that the edit session was successfully restored

This definitely shouldn't happen, again I would love to see the logs if this happens again.

@joyceerhl joyceerhl added this to the June 2022 milestone Jun 28, 2022
joyceerhl added a commit that referenced this issue Jun 29, 2022
@joyceerhl
Fix #153526
532cd0c
@joyceerhl joyceerhl mentioned this issue Jun 29, 2022
Merged
joyceerhl added a commit that referenced this issue Jun 29, 2022
@joyceerhl
Fix #153526 (#153766)
f1abeea
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 29, 2022
@joyceerhl joyceerhl reopened this Jun 30, 2022
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 30, 2022
@joyceerhl joyceerhl mentioned this issue Jun 30, 2022
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 30, 2022
@joyceerhl
Copy link
Contributor

Verification steps:

  1. Sign out of edit sessions via the accounts menu on insiders.vscode.dev and desktop VS Code Insiders
  2. Store an edit session from desktop, sign in when prompted
  3. Restore edit session from web, sign in when prompted
  4. Store edit session from web, ensure you are not prompted to auth
  5. Restore edit session from desktop, ensure you are not prompted to auth as well

@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 1, 2022
@rzhao271 rzhao271 removed the info-needed Issue requires more information from poster label Jul 1, 2022
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jul 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joyceerhl joyceerhl

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2022
5 participants
@TylerLeonhardt @lszomoru @rzhao271 @joyceerhl @VSCodeTriageBot