Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] - Test tasks shouldn't be triggered by build command (vice versa) #154064

Closed
jasonwilliams opened this issue Jul 4, 2022 · 0 comments · Fixed by #164983
Closed

[Bug] - Test tasks shouldn't be triggered by build command (vice versa) #154064

jasonwilliams opened this issue Jul 4, 2022 · 0 comments · Fixed by #164983
Assignees
@meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone
November 2022

Comments

@jasonwilliams
Copy link
Contributor

jasonwilliams commented Jul 4, 2022 •
edited

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.68.1
  • OS Version: MacOS 12.4

I worked on the feature to introduce globs on tasks along with alexr00.

However I've noticed currently I am running a test task when trying to build the project which is wrong. This behaviour is unexpected and was not possible before globs were introduced. It shouldn't be possible to execute a test task from a build command, or a build task from a test command.

Test Case

What happens

The task glob for kind: test executes

What's expected

The build task should execute because that's the only build task in the list of tasks so becomes the default as specified here

I didn't run Tasks: Run Test Task so the test task should not have executed

Hey @alexr00 I think one of your refactoring changes may have introduced this, is this something you're able to fix?
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Jul 5, 2022
@meganrogge meganrogge added this to the Backlog milestone Jul 5, 2022
@jasonwilliams jasonwilliams mentioned this issue Oct 29, 2022
Merged
meganrogge pushed a commit that referenced this issue Nov 1, 2022
@jasonwilliams
fix #154064 which was running the wrong taskgroups (#164983)
a46fb19
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 1, 2022
@rzhao271 rzhao271 modified the milestones: Backlog, November 2022 Nov 28, 2022
@connor4312 connor4312 added the verified Verification succeeded label Dec 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

fix #154064 which was running the wrong taskgroups jasonwilliams/vscode
5 participants
@jasonwilliams @connor4312 @rzhao271 @meganrogge @VSCodeTriageBot